[issue33416] Add endline and endcolumn to every AST node

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33416] Add endline and endcolumn to every AST node

miss-islington added the comment: New changeset 45da7437f54b4a6bdb8b4ba5a0f13f44a24eec39 by Miss Islington (bot) in branch '3.8': [3.8] bpo-33416: Document changes in PyNode_AddChild and PyParser_AddToken (GH-14214) (GH-14215)

[issue33416] Add endline and endcolumn to every AST node

Change by miss-islington : -- pull_requests: +14054 pull_request: https://github.com/python/cpython/pull/14215 ___ Python tracker ___

[issue33416] Add endline and endcolumn to every AST node

Change by Ivan Levkivskyi : -- pull_requests: +14052 pull_request: https://github.com/python/cpython/pull/14214 ___ Python tracker ___

[issue33416] Add endline and endcolumn to every AST node

Guido van Rossum added the comment: It seems we're keeping the new PyCode_New() signature, so we can do the same here. Just document it; a versionchanged (if there isn't one yet) and a mention in What's New sound appropriate. -- ___ Python

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: So what was the conclusion about PyCode_New()? Situation is quite similar here (except that these functions are used less often). Should we just document the changes in What's New? -- ___ Python tracker

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: Re-opening to track renaming of potentially public PyNode_AddChild() and PyParser_AddToken(). -- nosy: +vstinner resolution: fixed -> stage: resolved -> patch review status: closed -> open ___ Python tracker

[issue33416] Add endline and endcolumn to every AST node

Change by Emily Morehouse : -- pull_requests: +11441 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: Buildbots are green, this can be now closed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: New changeset 9932a22897ef9905161dac7476e6976370e13515 by Ivan Levkivskyi in branch 'master': bpo-33416: Add end positions to Python AST (GH-11605) https://github.com/python/cpython/commit/9932a22897ef9905161dac7476e6976370e13515 --

[issue33416] Add endline and endcolumn to every AST node

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33416] Add endline and endcolumn to every AST node

Change by Ivan Levkivskyi : -- keywords: +patch, patch, patch pull_requests: +11329, 11330, 11331 stage: -> patch review ___ Python tracker ___

[issue33416] Add endline and endcolumn to every AST node

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +11329 stage: -> patch review ___ Python tracker ___ ___

[issue33416] Add endline and endcolumn to every AST node

Change by Ivan Levkivskyi : -- keywords: +patch, patch pull_requests: +11329, 11330 stage: -> patch review ___ Python tracker ___

[issue33416] Add endline and endcolumn to every AST node

Aivar Annamaa added the comment: I strongly support this feature, because my IDE (https://thonny.org) needs to highlight AST nodes in the source code. There would be many interested parties if you count the stars of this project: https://github.com/gristlabs/asttokens -- nosy:

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: > I'm sure we will find use cases though I doubt that many compiler syntax > errors would benefit (since a syntax error means that we don't have a > completely matched grammar rule). This is mostly useful for code analysis tools and IDEs. > BTW, does this

[issue33416] Add endline and endcolumn to every AST node

Serhiy Storchaka added the comment: It is up to you Ivan. The end location can not be deduces from the start location of next sibling node or from the parent node. For example, the AST for the expression "foo.bar.baz" does not contain information for the end location of "foo.bar".

[issue33416] Add endline and endcolumn to every AST node

Raymond Hettinger added the comment: This idea seems reasonable. Most of the AST nodes have a span and it would be nice to know what that is. I'm sure we will find use cases though I doubt that many compiler syntax errors would benefit (since a syntax error means that we don't have a

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: FYI, I started working on this. I will have PR ready end of next week. Serhiy, I don't think we should keep both this and issue22616 open. Which one would you prefer to close? -- ___ Python tracker

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: issue22616 is a bit different (proposing line/column ranges instead of just endline/endcolumn). I am happy to close this one in favor of issue22616 if we agree that we will go with endline/endcolumn. I can't guarantee, but likely I will work on this during

[issue33416] Add endline and endcolumn to every AST node

Serhiy Storchaka added the comment: This may be a duplicate of issue22616. See also issue16795, issue21295, issue33211, issue34876. -- ___ Python tracker ___

[issue33416] Add endline and endcolumn to every AST node

Change by Raymond Hettinger : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33416] Add endline and endcolumn to every AST node

Serhiy Storchaka added the comment: I like this. This can help to generate more meaningful error messages at compile and run time. -- ___ Python tracker ___

[issue33416] Add endline and endcolumn to every AST node

New submission from Ivan Levkivskyi : Some Python tools (in particular I am interested in type checkers) will benefit from knowing where a given expression ends to indicate/highlight location of an error in the source code. Other tools and IDEs may have also some other