[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-31 Thread Ned Deily
Change by Ned Deily : -- nosy: -ned.deily priority: release blocker -> versions: -Python 3.7 ___ Python tracker ___ ___

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-31 Thread Paul Koning
Paul Koning added the comment: FYI, I'm the one who created this problem back in 2012. I just submitted a GDB patch for this, using PyImport_AppendInittab to define the built-in module at startup. I'm not sure how I missed this originally; perhaps the documentation was not as clear back

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-22 Thread STINNER Victor
STINNER Victor added the comment: > Also, the actual removal of the "modules" field was reverted. Oh... I didn't understand that part :-) Ok. In this case it's fine to close this documentation issue. Nothing should be documented for 3.7 ;-) --

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-21 Thread Eric Snow
Eric Snow added the comment: Under Py_LIMITED_API: typedef struct _is PyInterpreterState; Also, the actual removal of the "modules" field was reverted. The field is still there until I get back to fixing https://github.com/python/cpython/pull/3606.

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-18 Thread STINNER Victor
STINNER Victor added the comment: > Sorry for mixing two things here, but I meant that I found out about this > because of the private API use in gdb, however nothing from the change is > documented on whatsnew at all. It seems like there is at least one change in the

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-15 Thread Miro Hrončok
Miro Hrončok added the comment: Sorry for mixing two things here, but I meant that I found out about this because of the private API use in gdb, however nothing from the change is documented on whatsnew at all. This bug was a reaction for

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-15 Thread STINNER Victor
STINNER Victor added the comment: Oh, I'm sorry, I misunderstood the issue. Changes in the *private* API must not be documented. In short, you must not use the private API :-) If you really have to use the private API, be prepared for incompatible changes in new Python

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-15 Thread Eric Snow
Eric Snow added the comment: Yeah, I added an extra parameter. Since it's an internal API I didn't think anything of it. -- ___ Python tracker

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-12 Thread Miro Hrončok
Miro Hrončok added the comment: The change is a bit beyond my understanding ATM. I might be able to study it and stitch something up, but I'd rather leave it to the author of the change. -- ___ Python tracker

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-12 Thread STINNER Victor
STINNER Victor added the comment: Is it a release blocker? -- nosy: +ned.deily priority: normal -> release blocker ___ Python tracker

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-12 Thread STINNER Victor
STINNER Victor added the comment: Miro: do you want to work on a pull request? -- ___ Python tracker ___

[issue33470] Changes from GH-1638 (GH-3575, bpo-28411) are not documented in Porting to Python 3.7

2018-05-12 Thread Miro Hrončok
New submission from Miro Hrončok : Background: gdb fails to build with Python 3.7 as described in https://bugzilla.redhat.com/show_bug.cgi?id=1577396 This is due to _PyImport_FixupBuiltin changing it's API. I feel that _underscored functions are probably not guaranteed to not