[issue33652] Improve pickling of typing types

Ivan Levkivskyi added the comment: I think this can be closed now. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33652] Improve pickling of typing types

miss-islington added the comment: New changeset 98b089e2a178a309f20ac9ff498b230407da1f47 by Miss Islington (bot) in branch '3.7': bpo-33652: Remove __getstate__ and __setstate__ methods in typing. (GH-7144)

[issue33652] Improve pickling of typing types

Change by miss-islington : -- pull_requests: +6782 ___ Python tracker ___

[issue33652] Improve pickling of typing types

Ivan Levkivskyi added the comment: New changeset 97b523db7c79c18c48516fba9410014d9896abc4 by Ivan Levkivskyi (Serhiy Storchaka) in branch 'master': bpo-33652: Remove __getstate__ and __setstate__ methods in typing. (GH-7144)

[issue33652] Improve pickling of typing types

Change by Serhiy Storchaka : -- pull_requests: +6778 ___ Python tracker ___ ___

[issue33652] Improve pickling of typing types

Ivan Levkivskyi added the comment: Yes, these are just legacy from times when TypeVars were serialized by value, not by identity like now. I think it should be safe to remove them. Would you like to make a PR? -- ___ Python

[issue33652] Improve pickling of typing types

Serhiy Storchaka added the comment: There is a question -- what to do with all these __getstate__ and __setstate__ methods? They are part of the pickle protocol, but they are not used when define __reduce__. And they are not needed for supporting compatibility

[issue33652] Improve pickling of typing types

miss-islington added the comment: New changeset d49862582ed3513debed6e919fd4f92e9d4eebbd by Miss Islington (bot) in branch '3.7': bpo-33652: Improve pickle support in the typing module. (GH-7123)

[issue33652] Improve pickling of typing types

Change by miss-islington : -- pull_requests: +6766 ___ Python tracker ___

[issue33652] Improve pickling of typing types

Ivan Levkivskyi added the comment: New changeset 09f3221fbbf72692308149054e4f7668b08b22eb by Ivan Levkivskyi (Serhiy Storchaka) in branch 'master': bpo-33652: Improve pickle support in the typing module. (GH-7123)

[issue33652] Improve pickling of typing types

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +6758 stage: -> patch review ___ Python tracker ___

[issue33652] Improve pickling of typing types

New submission from Serhiy Storchaka : The following PR makes pickles for typing types more portable. Type variables no longer use _find_name() and can be unpickled in 3.6. Subscripted generics no longer expose internals and can be unpickled in 3.6 and future