[issue33738] PyIndex_Check conflicts with PEP 384

STINNER Victor added the comment: Ned: > @serhiy, @Christian: Is there anything more needed to be done for this issue > or can we close it? The issue is fixed in Python 3.8, I close it. See also bpo-40170 "[C API] Make PyTypeObject structure an opaque structure in the public C API" which

[issue33738] PyIndex_Check conflicts with PEP 384

Ned Deily added the comment: @serhiy, @Christian: Is there anything more needed to be done for this issue or can we close it? -- ___ Python tracker ___

[issue33738] PyIndex_Check conflicts with PEP 384

Serhiy Storchaka added the comment: New changeset 5cbefa99198729a1d4e93d93f890c066039ee1d2 by Serhiy Storchaka in branch 'master': Clean up after bpo-33738. (GH-7627) https://github.com/python/cpython/commit/5cbefa99198729a1d4e93d93f890c066039ee1d2 --

[issue33738] PyIndex_Check conflicts with PEP 384

STINNER Victor added the comment: AMD64 Windows8.1 Non-Debug 3.x buildbot is back to green. -- ___ Python tracker ___ ___

[issue33738] PyIndex_Check conflicts with PEP 384

Change by Serhiy Storchaka : -- pull_requests: +7246 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33738] PyIndex_Check conflicts with PEP 384

Ned Deily added the comment: Sigh! I was hoping we could get this in for 3.7.0 but I think we have run out of time and we really should not be making potential user-visible API changes at this last minute. I did notice the new compile warning for the Windows non-debug build but I

[issue33738] PyIndex_Check conflicts with PEP 384

Ned Deily added the comment: New changeset 8398713cea0eb17b013f25f86bef47c7e5e63139 by Ned Deily (Christian Tismer) in branch 'master': bpo-33738: Address review comments in GH #7477 (GH-7585) https://github.com/python/cpython/commit/8398713cea0eb17b013f25f86bef47c7e5e63139 --

[issue33738] PyIndex_Check conflicts with PEP 384

Change by Serhiy Storchaka : -- pull_requests: +7227 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33738] PyIndex_Check conflicts with PEP 384

Christian Tismer added the comment: @Victor I cannot test on Windows because I'm in vacation. But it is very likely similar to bpo-33614 . The three missing symbols which are listed in python3.def do clearly come into existence when the limited API is active. --

[issue33738] PyIndex_Check conflicts with PEP 384

Change by Christian Tismer : -- pull_requests: +7207 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33738] PyIndex_Check conflicts with PEP 384

STINNER Victor added the comment: It seems like the change broke compilation on Windows, but I'm not sure: http://buildbot.python.org/all/#/builders/12/builds/959 (Link target) -> python3.def : error LNK2001: unresolved external symbol PyExceptionClass_Name

[issue33738] PyIndex_Check conflicts with PEP 384

Serhiy Storchaka added the comment: You are right Christian. I missed that PyTypeObject is opaque if Py_LIMITED_API is defined. -- ___ Python tracker ___

[issue33738] PyIndex_Check conflicts with PEP 384

Ned Deily added the comment: As I noted on PR 7477, I decided to merge the change to master so it would get some buildbot exposure before deciding whether to backport for 3.7.0rc1 which is coming up shortly. I notice that the change introduced a compiler warning. Should that be fixed?

[issue33738] PyIndex_Check conflicts with PEP 384

Ned Deily added the comment: New changeset ea62ce7f4fefc66bc0adba16bcd7666d5bbd5b44 by Ned Deily (Christian Tismer) in branch 'master': bpo-33738: Fix macros which contradict PEP 384 (GH-7477) https://github.com/python/cpython/commit/ea62ce7f4fefc66bc0adba16bcd7666d5bbd5b44 --

[issue33738] PyIndex_Check conflicts with PEP 384

Christian Tismer added the comment: """Excluding names from limited API can break existing code that use them with defined Py_LIMITED_API.""" How is that different? Right now, the code would break at compile time, because the macros are accessing opaque type fields. Excluding them has the

[issue33738] PyIndex_Check conflicts with PEP 384

Serhiy Storchaka added the comment: Excluding names from limited API can break existing code that use them with defined Py_LIMITED_API. I wondering if corresponding functions should be added for PySequence_ITEM, PyObject_IS_GC, PyType_SUPPORTS_WEAKREFS, PyObject_GET_WEAKREFS_LISTPTR.

[issue33738] PyIndex_Check conflicts with PEP 384

Christian Tismer added the comment: On 07.06.18 17:59, Eric Snow wrote: > > Eric Snow added the comment: > > @Christian, you can use the "blurb" tool to create the NEWS entry. You can > use pip to install it. See: > > >

[issue33738] PyIndex_Check conflicts with PEP 384

Eric Snow added the comment: @Christian, you can use the "blurb" tool to create the NEWS entry. You can use pip to install it. See: https://devguide.python.org/committing/?highlight=blurb#what-s-new-and-news-entries -- nosy: +eric.snow ___

[issue33738] PyIndex_Check conflicts with PEP 384

Change by Christian Tismer : -- pull_requests: -7096 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33738] PyIndex_Check conflicts with PEP 384

Change by Christian Tismer : -- pull_requests: -6956 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33738] PyIndex_Check conflicts with PEP 384

Christian Tismer added the comment: I did not understand the Misc/NEWS.d thing. What should go where, or where would a "skip news" label go? -- ___ Python tracker ___

[issue33738] PyIndex_Check conflicts with PEP 384

Change by Christian Tismer : -- pull_requests: +7100 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33738] PyIndex_Check conflicts with PEP 384

Change by Christian Tismer : -- pull_requests: +7096 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33738] PyIndex_Check conflicts with PEP 384

Ned Deily added the comment: Thanks, Christian! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33738] PyIndex_Check conflicts with PEP 384

Christian Tismer added the comment: Hi Ned, we had a delivery date yesterday for PySide. The PR is almost ready and will go out today. Ciao - Chris On 07.06.18 09:43, Ned Deily wrote: > > Ned Deily added the comment: > > Christian, any progress on this? 3.7.0rc1 is planned to be tagged

[issue33738] PyIndex_Check conflicts with PEP 384

Ned Deily added the comment: Christian, any progress on this? 3.7.0rc1 is planned to be tagged in 4 days, on Monday 2018-06-11. Do you think you will be able to provide a PR before then? -- ___ Python tracker

[issue33738] PyIndex_Check conflicts with PEP 384

Antoine Pitrou added the comment: > related personal note - does someone know what happened to Martin? I don't think anything bad happened. He still seems to be teaching: http://www.beuth-hochschule.de/people/detail/1398/ -- nosy: +pitrou ___

[issue33738] PyIndex_Check conflicts with PEP 384

Christian Tismer added the comment: Yes, sure, I will submit a patch that tries to reach as much as possible locations that have a similar problem. Of course, the code will only be turned into functions for the PEP context. Takes a day because I need to re-learn a bit how to do this :-) (last

[issue33738] PyIndex_Check conflicts with PEP 384

Serhiy Storchaka added the comment: Would be nice if you fix as much similar as you can with a single PR. For performance it makes sense to keep macros if the limited API is not used. -- ___ Python tracker

[issue33738] PyIndex_Check conflicts with PEP 384

Christian Tismer added the comment: Ok, I tried to submit a patch (not yet successful), but as it stands, there are more locations in the code where this will show up with similar problems. Should I take care of these all as much as I can, or is it better to leave it to one of you? Whatever

[issue33738] PyIndex_Check conflicts with PEP 384

Serhiy Storchaka added the comment: Seems PyIter_Check and PySequence_ITEM have the same problem. And maybe more. -- ___ Python tracker ___

[issue33738] PyIndex_Check conflicts with PEP 384

Ned Deily added the comment: This is not a security issue so a change would not be applicable to the 3.4 or 3.5 branches, currently in security-fix-only mode. -- versions: +Python 3.8 -Python 3.4, Python 3.5 ___ Python tracker

[issue33738] PyIndex_Check conflicts with PEP 384

Change by Christian Tismer : -- keywords: +patch pull_requests: +6956 stage: -> patch review ___ Python tracker ___ ___

[issue33738] PyIndex_Check conflicts with PEP 384

Change by Ned Deily : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33738] PyIndex_Check conflicts with PEP 384

New submission from Christian Tismer : The file number.rst on python 3.6 says """ .. c:function:: int PyIndex_Check(PyObject *o) Returns ``1`` if *o* is an index integer (has the nb_index slot of the tp_as_number structure filled in), and ``0`` otherwise. """ But in reality, this is a