[issue33758] Unexpected success of test_get_type_hints_modules_forwardref in test_typing

miss-islington added the comment: New changeset fad89046e14b271b2eeb399f7c7b45131d65e5f2 by Miss Islington (bot) in branch '3.7': closes bpo-33758: Skip test_get_type_hints_modules_forwardref. (GH-13977) https://github.com/python/cpython/commit/fad89046e14b271b2eeb399f7c7b45131d65e5f2

[issue33758] Unexpected success of test_get_type_hints_modules_forwardref in test_typing

miss-islington added the comment: New changeset 1c31d19e35172c7de1beec5c48a5b632d16385d9 by Miss Islington (bot) in branch '3.8': closes bpo-33758: Skip test_get_type_hints_modules_forwardref. (GH-13977) https://github.com/python/cpython/commit/1c31d19e35172c7de1beec5c48a5b632d16385d9

[issue33758] Unexpected success of test_get_type_hints_modules_forwardref in test_typing

Change by miss-islington : -- pull_requests: +13846 pull_request: https://github.com/python/cpython/pull/13979 ___ Python tracker ___

[issue33758] Unexpected success of test_get_type_hints_modules_forwardref in test_typing

Change by miss-islington : -- pull_requests: +13845 pull_request: https://github.com/python/cpython/pull/13978 ___ Python tracker ___

[issue33758] Unexpected success of test_get_type_hints_modules_forwardref in test_typing

Benjamin Peterson added the comment: New changeset 910b3fcb01c29f18ffd53086e36cd2cb9e5fae55 by Benjamin Peterson in branch 'master': closes bpo-33758: Skip test_get_type_hints_modules_forwardref. (GH-13977) https://github.com/python/cpython/commit/910b3fcb01c29f18ffd53086e36cd2cb9e5fae55

[issue33758] Unexpected success of test_get_type_hints_modules_forwardref in test_typing

Change by Benjamin Peterson : -- keywords: +patch pull_requests: +13844 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13977 ___ Python tracker

[issue33758] Unexpected success of test_get_type_hints_modules_forwardref in test_typing

Ivan Levkivskyi added the comment: Likely, the unexpected success can be avoided with clearing generic caches in test___all__ (it just imports whatever it can find and likely also test/mod_generics_cache.py), but I am also fine with just skipping it for now. Will you have time to make a PR?

[issue33758] Unexpected success of test_get_type_hints_modules_forwardref in test_typing

Benjamin Peterson added the comment: In particular, test_typing has an unexpected success if you run it after test___all__. It would be nice at least to change the expected fail to a skip, since it's so subtle. -- nosy: +benjamin.peterson ___

[issue33758] Unexpected success of test_get_type_hints_modules_forwardref in test_typing

Ivan Levkivskyi added the comment: Oh yes, this is a "stateful" bug. It will not appear if run in isolation. Btw, the underlying bug will be worse with `from __future__ import annotations`, so it would make sense to fix this sooner than later. -- nosy: +lukasz.langa

[issue33758] Unexpected success of test_get_type_hints_modules_forwardref in test_typing

New submission from Serhiy Storchaka : $ ./python -m test -v -m test_get_type_hints_modules_forwardref test_typing ... test_get_type_hints_modules_forwardref (test.test_typing.GetTypeHintTests) ... unexpected success -- Ran 1