[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

STINNER Victor added the comment: I was decided to only fix the bug in the master branch, since it's a minor bug (leak a few handles in a rare case), whereas the backport can introduce regressions. https://github.com/python/cpython/pull/7921#issuecomment-400612321 The bug has been fixed in

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

STINNER Victor added the comment: New changeset 0aab8660cdaa540730994afbce49a146dd779bce by Victor Stinner in branch 'master': bpo-33929: Fix regression in spawn_main() (#7962) https://github.com/python/cpython/commit/0aab8660cdaa540730994afbce49a146dd779bce --

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

STINNER Victor added the comment: New changeset 7b5856e7f059748f41f37d00abc76be0807d989d by Victor Stinner in branch '3.7': Revert "bpo-33929: multiprocessing: fix handle leak on race condition (GH-7921)" (GH-7963)

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

Change by STINNER Victor : -- pull_requests: +7570 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

miss-islington added the comment: New changeset 8b1ebcd7cb3319273ea635df78ebf9ad40171514 by Miss Islington (bot) in branch '3.7': bpo-33929: multiprocessing: fix handle leak on race condition (GH-7921) https://github.com/python/cpython/commit/8b1ebcd7cb3319273ea635df78ebf9ad40171514

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

Change by STINNER Victor : -- pull_requests: +7569 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

Change by STINNER Victor : -- pull_requests: +7568 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

STINNER Victor added the comment: Python 2.7 is not affected: it doesn't use DuplicateHandle() with DUPLICATE_CLOSE_SOURCE. -- versions: +Python 3.6, Python 3.7 ___ Python tracker

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

Change by miss-islington : -- pull_requests: +7567 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

STINNER Victor added the comment: New changeset 2cc9d21fffb8146d30e6fb4221e32410ba4b4ab7 by Victor Stinner in branch 'master': bpo-33929: multiprocessing: fix handle leak on race condition (GH-7921) https://github.com/python/cpython/commit/2cc9d21fffb8146d30e6fb4221e32410ba4b4ab7

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

STINNER Victor added the comment: See also bpo-33966: test_multiprocessing_spawn.WithProcessesTestPool.test_traceback() leaks 4 handles on Windows. -- ___ Python tracker

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

STINNER Victor added the comment: It seems like Popen of multiprocess.popen_spawn_win32 has a race condition. If the child process is killed in the parent using terminate() before the child process "steals" rhandle, rhandle remains open. I wrote the PR 7921 to fix it. --

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

Change by STINNER Victor : -- keywords: +patch pull_requests: +7527 stage: -> patch review ___ Python tracker ___ ___

[issue33929] test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows

Change by STINNER Victor : -- title: test_multiprocessing_spawn leaks 5 handles -> test_multiprocessing_spawn: WithProcessesTestProcess.test_many_processes() leaks 5 handles on Windows ___ Python tracker