[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

STINNER Victor added the comment: Serhiy Storchaka: """ Objects/unicodeobject.c: In function ‘_PyUnicode_FastFill’: Objects/unicodeobject.c:10126:24: warning: passing argument 2 of ‘unicode_fill’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] """ Yeah, I was

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

STINNER Victor added the comment: New changeset 54fa83e0a3f3b077763cb50705d7a7dbe4a40a4a by Victor Stinner in branch '3.6': bpo-33954: Rewrite FILL() macro of unicodeobject.c (GH-10740) https://github.com/python/cpython/commit/54fa83e0a3f3b077763cb50705d7a7dbe4a40a4a --

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

STINNER Victor added the comment: New changeset 7f9fb0f34555641722be5468b7fbd53dd3c0f1e2 by Victor Stinner in branch '3.7': bpo-33954: Rewrite FILL() macro of unicodeobject.c (GH-10738) https://github.com/python/cpython/commit/7f9fb0f34555641722be5468b7fbd53dd3c0f1e2 --

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

STINNER Victor added the comment: New changeset 163403a63e9272fcd14707e344122c2e3c5e0244 by Victor Stinner in branch 'master': bpo-33954: Fix compiler warning in _PyUnicode_FastFill() (GH-10737) https://github.com/python/cpython/commit/163403a63e9272fcd14707e344122c2e3c5e0244 --

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

Change by STINNER Victor : -- pull_requests: +9987 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

Change by STINNER Victor : -- pull_requests: +9985 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

Change by STINNER Victor : -- pull_requests: +9984 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

Serhiy Storchaka added the comment: Objects/unicodeobject.c: In function ‘_PyUnicode_FastFill’: Objects/unicodeobject.c:10126:24: warning: passing argument 2 of ‘unicode_fill’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] unicode_fill(kind, data, fill_char,

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

STINNER Victor added the comment: Python 3.6, 3.7 and master have been fixed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

STINNER Victor added the comment: New changeset fc4a44b0c3a69390eca4680d89c2ae5fe967f882 by Victor Stinner in branch '3.6': bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (GH-10623) (GH-10718) (GH-10720) https://github.com/python/cpython/commit/fc4a44b0c3a69390eca4680d89c2ae5fe967f882

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

Change by STINNER Victor : -- pull_requests: +9968 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

STINNER Victor added the comment: New changeset 6f5fa1b4be735159e964906ab608dc467476e47c by Victor Stinner in branch '3.7': bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (GH-10623) (GH-10718) https://github.com/python/cpython/commit/6f5fa1b4be735159e964906ab608dc467476e47c --

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

Change by STINNER Victor : -- pull_requests: +9967 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

Change by miss-islington : -- pull_requests: +9966 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

STINNER Victor added the comment: New changeset 59423e3ddd736387cef8f7632c71954c1859bed0 by Victor Stinner in branch 'master': bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (GH-10623) https://github.com/python/cpython/commit/59423e3ddd736387cef8f7632c71954c1859bed0 --

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

STINNER Victor added the comment: My private test suite for locales: https://github.com/vstinner/misc/blob/master/python/test_all_locales.py Since each platform uses a different locale database, it's hard to write reliable portable and future-proof tests :-( My tests only work on specific

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

STINNER Victor added the comment: Minimum reproducer, on Fedora 29: import locale locale.setlocale(locale.LC_ALL, 'fr_FR.UTF-8') print(ascii('{:n}'.format(1.5))) Current result: 'H,5' Output with PR 10623: '1,5' -- ___ Python tracker

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

Change by STINNER Victor : -- keywords: +patch pull_requests: +9871 stage: -> patch review ___ Python tracker ___ ___

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

Change by ppperry : -- title: float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error -> float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator ___ Python