[issue34006] Windows HTML Help (chm) has fixed line length

Change by Terry J. Reedy : -- assignee: -> terry.reedy resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34006] Windows HTML Help (chm) has fixed line length

miss-islington added the comment: New changeset 580c7db172a41d6311c0f3a7aec321597576e214 by Miss Islington (bot) in branch '3.6': bpo-34006: Revert line length limit for Windows help docs (GH-8051) https://github.com/python/cpython/commit/580c7db172a41d6311c0f3a7aec321597576e214 --

[issue34006] Windows HTML Help (chm) has fixed line length

miss-islington added the comment: New changeset 4d02ad856f123d68712f542d55e8ff3393f00a8f by Miss Islington (bot) in branch '3.7': bpo-34006: Revert line length limit for Windows help docs (GH-8051) https://github.com/python/cpython/commit/4d02ad856f123d68712f542d55e8ff3393f00a8f --

[issue34006] Windows HTML Help (chm) has fixed line length

Change by miss-islington : -- pull_requests: +7662 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34006] Windows HTML Help (chm) has fixed line length

Change by miss-islington : -- pull_requests: +7661 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34006] Windows HTML Help (chm) has fixed line length

Terry J. Reedy added the comment: New changeset d824ca7f4df9b5f77cf02490b0e98c2408e21fee by Terry Jan Reedy (Zachary Ware) in branch 'master': bpo-34006: Revert line length limit for Windows help docs (GH-8051) https://github.com/python/cpython/commit/d824ca7f4df9b5f77cf02490b0e98c2408e21fee

[issue34006] Windows HTML Help (chm) has fixed line length

Change by Joseph L. Casale : -- nosy: -jcasale ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34006] Windows HTML Help (chm) has fixed line length

Terry J. Reedy added the comment: The patch now works for me and can be tested. The blurb is added and can be reviewed. I expect to merge within a day. -- ___ Python tracker

[issue34006] Windows HTML Help (chm) has fixed line length

Terry J. Reedy added the comment: Yes, I will add a blurb and merge and backport, when the patch is modified to change htmlhelp rather than htmlview. -- ___ Python tracker

[issue34006] Windows HTML Help (chm) has fixed line length

Zachary Ware added the comment: Terry: PR8051 should do that, but I haven't tested it. Would you mind taking over the PR if it does what you want it to? -- ___ Python tracker

[issue34006] Windows HTML Help (chm) has fixed line length

Change by Zachary Ware : -- keywords: +patch pull_requests: +7659 stage: -> patch review ___ Python tracker ___ ___

[issue34006] Windows HTML Help (chm) has fixed line length

Terry J. Reedy added the comment: Zach, I believe you helped write make.bat. I can run 'make htmlhelp', but I don't know how to modify make.bat to add option "-D html_theme_options.body_max_width=none" specifically when building htmlhelp. -- ___

[issue34006] Windows HTML Help (chm) has fixed line length

gladman added the comment: I cannot build the Windows chm file but I am happy to test any versions that others can produce. -- ___ Python tracker ___

[issue34006] Windows HTML Help (chm) has fixed line length

Julien Palard added the comment: > Maybe, all you we need to do is adding "-D > html_theme_options.body_max_width=none" option to sphinx-build when building > html for htmlhelp, in Doc/make.bat. As far as I can see, it's the right solution, but I have no windows machine to test it. I

[issue34006] Windows HTML Help (chm) has fixed line length

INADA Naoki added the comment: http://www.sphinx-doc.org/en/master/theming.html#builtin-themes > body_max_width (int or str): Maximal width of the document body. This can be > an int, which is interpreted as pixels or a valid CSS dimension string such > as ‘70em’ or ‘50%’. Use ‘none’ if you

[issue34006] Windows HTML Help (chm) has fixed line length

INADA Naoki added the comment: I prefer limiting width on browser, but I'm OK to remove limitation from chm files. Rational: Changing window size to control line width for readable length is bad UX because all modern browsers are tabbed. Or it may be impossible on iPad. On the other

[issue34006] Windows HTML Help (chm) has fixed line length

Ned Deily added the comment: nosying Julien -- nosy: +mdk, ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34006] Windows HTML Help (chm) has fixed line length

Terry J. Reedy added the comment: The change is also in 3.6.6, released the same day as 3.7.0. It was done intentionally, without, as far as I know, consulting Python doc users. Users were previously free to select the max line width they wanted. On

[issue34006] Windows HTML Help (chm) has fixed line length

Steve Dower added the comment: > I want to deprecate chm because it uses legacy HTML ... Agreed, but not without a replacement. -- ___ Python tracker ___

[issue34006] Windows HTML Help (chm) has fixed line length

INADA Naoki added the comment: Hmm, I want to deprecate chm because it uses legacy HTML (doesn't support UTF-8!), hard to build, hard to confirm issues -- ___ Python tracker

[issue34006] Windows HTML Help (chm) has fixed line length

gladman added the comment: You are exactly right Steve - that is very close to what I am seeing and it is often quite hard to read. For example, where function prototypes are displayed on two lines, it takes me a lot longer to parse and understand them when compared with a situation where

[issue34006] Windows HTML Help (chm) has fixed line length

Steve Dower added the comment: It's pretty annoying when HTML Help doesn't properly handle your screen scaling settings (guessing my new screenshot looks like gladman's). I'd love to have a new HTML Help program for our docs that could handle this better, but there's nothing in the same

[issue34006] Windows HTML Help (chm) has fixed line length

Steve Dower added the comment: Let's try adding that screenshot again... -- Added file: https://bugs.python.org/file47662/NarrowCHM.png ___ Python tracker ___

[issue34006] Windows HTML Help (chm) has fixed line length

INADA Naoki added the comment: I think this is not only chm, but same to all HTML based (online, zipped html, maybe ePub). max-width was added for readability. https://github.com/python/python-docs-theme/issues/4 There are no absolute right answer and there are many personal preferences.

[issue34006] Windows HTML Help (chm) has fixed line length

Change by Joseph L. Casale : -- nosy: +jcasale ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34006] Windows HTML Help (chm) has fixed line length

gladman added the comment: Comparing the basic.css files for the 3.6.5 chm file and the 3.6.6 chm file shows that the latter has the following body style definition that the earlier versions don't have: /* -- general body styles - */ div.body { min-width:

[issue34006] Windows HTML Help (chm) has fixed line length

Steve Dower added the comment: I agree. I don't think we deliberately changed anything here. Possibly the sphinx theme has some CSS that doesn't work well in IE, so that should be the starting point for someone to look. -- ___ Python tracker

[issue34006] Windows HTML Help (chm) has fixed line length

gladman added the comment: I too much prefer the old behaviour since the fixed width is too narrow on my high resolution display -- nosy: +gladman ___ Python tracker ___

[issue34006] Windows HTML Help (chm) has fixed line length

New submission from Roel Schroeven : Since 3.7 (and possibly 3.6.6) the .chm Windows help file uses fixed line lenghts, instead of properly adapting to the window width. Please revert to the old behavior. See screenshot: the empty space on the right is just silly. -- components: