[issue34200] importlib: python -m test test_pkg fails semi-randomly

STINNER Victor added the comment: Thank you for the fix Gregory! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34200] importlib: python -m test test_pkg fails semi-randomly

Gregory P. Smith added the comment: I still feel like there is an underlying issue within the import system that use of test.support.modules_cleanup somehow triggers that I never managed to really understand. but the particular issue in this bug that people were seeing frequently is fixed.

[issue34200] importlib: python -m test test_pkg fails semi-randomly

miss-islington added the comment: New changeset 3e3d4a4b55cbef481486aaa68ee255f4928b9c3f by Miss Islington (bot) in branch '3.6': bpo-34200: Fix non-determinism of test_pkg (GH-9248) https://github.com/python/cpython/commit/3e3d4a4b55cbef481486aaa68ee255f4928b9c3f --

[issue34200] importlib: python -m test test_pkg fails semi-randomly

miss-islington added the comment: New changeset 90f7d455b7f4bd53d3af11cb951347c9c8230399 by Miss Islington (bot) in branch '3.7': bpo-34200: Fix non-determinism of test_pkg (GH-9248) https://github.com/python/cpython/commit/90f7d455b7f4bd53d3af11cb951347c9c8230399 --

[issue34200] importlib: python -m test test_pkg fails semi-randomly

miss-islington added the comment: New changeset 4ae8ece5cd4c5853b625381db13429f25512108d by Miss Islington (bot) (Gregory P. Smith) in branch 'master': bpo-34200: Fix non-determinism of test_pkg (GH-9248) https://github.com/python/cpython/commit/4ae8ece5cd4c5853b625381db13429f25512108d

[issue34200] importlib: python -m test test_pkg fails semi-randomly

Change by miss-islington : -- pull_requests: +8684 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34200] importlib: python -m test test_pkg fails semi-randomly

Change by miss-islington : -- pull_requests: +8683 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34200] importlib: python -m test test_pkg fails semi-randomly

Gregory P. Smith added the comment: this is also present in 3.5, but it'll be up to the 3.5 release manager to cherry pick the test_pkg.py reliability fix into the 3.5 branch if it impacts them during the release process. -- versions: +Python 3.5

[issue34200] importlib: python -m test test_pkg fails semi-randomly

Jeremy Kloth added the comment: Did you attempt to use the 3-line change I posted earlier? I stepped through to test line-by-line to find the offending piece of code. And it was indeed the open() call causing the test-tree to be processed prior to it being completed. Thus making the .py

[issue34200] importlib: python -m test test_pkg fails semi-randomly

Change by Gregory P. Smith : -- keywords: +patch pull_requests: +8679 stage: -> patch review ___ Python tracker ___ ___

[issue34200] importlib: python -m test test_pkg fails semi-randomly

Gregory P. Smith added the comment: I can make the test reliable... but I wouldn't say I fully understand the ultimate cause of the problem. The reliability fix for test_pkg is to stop using test.support.modules_setup() and test.support.modules_cleanup() in the setUp() and tearDown()

[issue34200] importlib: python -m test test_pkg fails semi-randomly

Gregory P. Smith added the comment: kinda poking at ideas here, but from a lunch conversation could this be related to the filesystem iteration order within the temp directories. assigned to me while i investigate possibilities. -- ___ Python

[issue34200] importlib: python -m test test_pkg fails semi-randomly

Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34200] importlib: python -m test test_pkg fails semi-randomly

Gregory P. Smith added the comment: and I do agree that it is somewhat random. while i have some situations where I can reproduce this, i have others where I can rerun exactly the same binary and single process single thread process running just test_pkg.py and nothing else where the