[issue34248] dbm errors should contain file names

Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34248] dbm errors should contain file names

Berker Peksag added the comment: New changeset 9df346bf98069a87de14a3c2f69009d800994c63 by Berker Peksag (Zsolt Cserna) in branch 'master': bpo-34248: Add filename to error raised in {gnu,ndbm}.open() (GH-8590) https://github.com/python/cpython/commit/9df346bf98069a87de14a3c2f69009d800994c63

[issue34248] dbm errors should contain file names

Berker Peksag added the comment: PR 8590 only changes dbm.gnu. If we do this, we should update dbm.ndbm as well: https://github.com/python/cpython/blob/4a745333406a4b9c5b0194bdac4a77d9fadd5457/Modules/_dbmmodule.c#L65 -- nosy: +berker.peksag type: -> enhancement versions:

[issue34248] dbm errors should contain file names

Zsolt Cserna added the comment: Alright, I created a PR for this. We will see if this can be merged to upstream or not. -- ___ Python tracker ___

[issue34248] dbm errors should contain file names

Change by Zsolt Cserna : -- pull_requests: +8100 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34248] dbm errors should contain file names

sds added the comment: thanks for the patch. alas, I do not build python myself, so I cannot try it. -- ___ Python tracker ___ ___

[issue34248] dbm errors should contain file names

Zsolt Cserna added the comment: I've made a patch which works for me. >>> dbm.gnu.open("/tmp/z") Traceback (most recent call last): File "", line 1, in _gdbm.error: [Errno 2] No such file or directory: '/tmp/z' >>> Could you please give it a try? -- keywords: +patch

[issue34248] dbm errors should contain file names

New submission from sds : `dbm` errors should contain file names when appropriate, just like `OSError`. E.g.: ``` >>> open("fo") Traceback (most recent call last): File "", line 1, in FileNotFoundError: [Errno 2] No such file or directory: 'fo' >>> import dbm.gnu >>>