[issue34488] improve performance of BytesIO.writelines() by avoiding creation of unused PyLongs

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue34488] improve performance of BytesIO.writelines() by avoiding creation of unused PyLongs

Inada Naoki added the comment: New changeset 3e41f3cabb661824a1a197116f7f5ead64eb6ced by Inada Naoki (Sergey Fedoseev) in branch 'master': bpo-34488: optimize BytesIO.writelines() (GH-8904) https://github.com/python/cpython/commit/3e41f3cabb661824a1a197116f7f5ead64eb6ced --

[issue34488] improve performance of BytesIO.writelines() by avoiding creation of unused PyLongs

Change by Inada Naoki : -- components: +IO -Extension Modules versions: +Python 3.9 -Python 3.8 ___ Python tracker ___ ___

[issue34488] improve performance of BytesIO.writelines() by avoiding creation of unused PyLongs

Sergey Fedoseev added the comment: `BytesIO.write()` and `BytesIO.writelines()` are independent of each other. -- ___ Python tracker ___

[issue34488] improve performance of BytesIO.writelines() by avoiding creation of unused PyLongs

Inada Naoki added the comment: Hm, what happened if subclass of BytesIO overrides `write` but not `writelines`? -- nosy: +inada.naoki ___ Python tracker ___

[issue34488] improve performance of BytesIO.writelines() by avoiding creation of unused PyLongs

Change by Sergey Fedoseev : -- keywords: +patch pull_requests: +8374 stage: -> patch review ___ Python tracker ___ ___

[issue34488] improve performance of BytesIO.writelines() by avoiding creation of unused PyLongs

New submission from Sergey Fedoseev : Currently BytesIO.writelines() uses BytesIO.write() which returns number of written bytes as Python ints, but these ints are not used by BytesIO.writelines(), so avoiding creation of these ints can improve performance of BytesIO.writelines() especially