[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7 ___ Python tracker ___

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Serhiy Storchaka added the comment: New changeset 3a9b3346b03796d8573c063ab4c2407043609459 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-34604: Use %R because of invisible characters or trailing whitespaces. (GH-9165). (GH-10947) (GH-10954)

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Change by miss-islington : -- pull_requests: +10203 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Serhiy Storchaka added the comment: New changeset ac8b47c8b4edd59aaee857717d434df52ec49e6c by Serhiy Storchaka in branch '3.7': bpo-34604: Use %R because of invisible characters or trailing whitespaces. (GH-9165). (GH-10947)

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Change by Serhiy Storchaka : -- pull_requests: +10197 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Serhiy Storchaka added the comment: New changeset 34c7f0c04e2b4e715b2c3df1875af8939fbe7d0b by Serhiy Storchaka (William Grzybowski) in branch 'master': bpo-34604: Use %R because of invisible characters or trailing whitespaces. (GH-9165)

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Change by William Grzybowski : -- pull_requests: +8608 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

STINNER Victor added the comment: > I can do it if you feel the need. Can this same issue be used? Will the new > PR require another NEWS entry? Sure, reuse the same bpo number. You can modify the NEWS entry that you added ;-) -- ___ Python

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

William Grzybowski added the comment: I can do it if you feel the need. Can this same issue be used? Will the new PR require another NEWS entry? -- ___ Python tracker ___

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

STINNER Victor added the comment: The bug has been fixed. For %R, does someone want to propose a change for master? William? -- ___ Python tracker ___

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

STINNER Victor added the comment: New changeset 7a633ed79cfba2cfc0f80410ddcaeecadc2030e9 by Victor Stinner (William Grzybowski) in branch '3.7': [3.7] bpo-34604: Fix possible mojibake in pwd.getpwnam() and grp.getgrnam() (GH-9098) (GH-9104)

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

STINNER Victor added the comment: New changeset 1bcd891c200b8122493ddad5a203331e1a3bfcb5 by Victor Stinner (William Grzybowski) in branch '3.6': [3.6] bpo-34604: Fix possible mojibake in pwd.getpwnam() and grp.getgrnam() (GH-9098) (GH-9105)

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

William Grzybowski added the comment: What is the policy to amend a new commit to master for %R? Create a new PR? Wont that cause problem with NEWS entry? -- ___ Python tracker

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

STINNER Victor added the comment: %R sounds like a good idea, but I suggest to only use %R in the master branch. -- ___ Python tracker ___

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Serhiy Storchaka added the comment: Wouldn't be better to use %R? The name can contain invisible characters or trailing whitespaces, in which case the traceback can look confusing. Since names are likely created with PyUnicode_DecodeFSDefault(), they can contain undecodable bytes

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Change by William Grzybowski : -- pull_requests: +8559 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Change by William Grzybowski : -- pull_requests: +8558 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

STINNER Victor added the comment: New changeset 28658485a54ad5f9df52ecc12d9046269f1654ec by Victor Stinner (William Grzybowski) in branch 'master': bpo-34604: Fix possible mojibake in pwd.getpwnam() and grp.getgrnam() (GH-9098)

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Change by William Grzybowski : -- keywords: +patch pull_requests: +8552 stage: -> patch review ___ Python tracker ___ ___

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

Change by STINNER Victor : -- nosy: +vstinner versions: +Python 2.7 -Python 3.4, Python 3.5 ___ Python tracker ___ ___

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

New submission from William Grzybowski : Issue was spotted by @vstinner while reviewing https://github.com/python/cpython/pull/7081 pwd.getpwnam and grp.getgrnam are susceptible to mojibake as they are using encoded bytes instead of unicode in the error message. -- components: