[issue34632] Port importlib_metadata to Python 3.8

Arne Recknagel added the comment: I just learned that metadata is stored as an email, and changing the format was rejected in PEP 426. Be that as it may, if it isn't too much of an issue it might still be something that should be hidden from users of the module. Noone wants to know that

[issue34632] Port importlib_metadata to Python 3.8

Arne Recknagel added the comment: Is there a reason the object returned by importlib.metadata.metadata is an EmailMessage and not a dict? If it quacks like a duck it should be a duck, no? -- nosy: +arne ___ Python tracker

[issue34632] Port importlib_metadata to Python 3.8

Jason R. Coombs added the comment: I've addressed the requests made by rhettinger in issue38086 and issue38121. -- status: open -> closed ___ Python tracker ___

[issue34632] Port importlib_metadata to Python 3.8

Raymond Hettinger added the comment: > Following the same pattern that many standard Python objects > return (`open`, `map`, `filter`), the approach is less > constrained in that it can support arbitrarily large results. > I wished to leave it to the caller to materialize a list if > that

[issue34632] Port importlib_metadata to Python 3.8

Jason R. Coombs added the comment: > Is there a reason that requires() and files() return iterators instead of > lists? I'm a huge fan of `itertools` and Python 3's move to prefer iterables over materialized lists, and I feel that forcing materialized results gives the caller less control

[issue34632] Port importlib_metadata to Python 3.8

Barry A. Warsaw added the comment: @jaraco will be able to answer that better than me. I actually thought those did return concrete lists. I also thought that the APIs accepted either a module or a package name, but maybe I'm thinking about importlib.resources. Again, @jaraco can clarify,

[issue34632] Port importlib_metadata to Python 3.8

Raymond Hettinger added the comment: Quick question: Is there a reason that requires() and files() return iterators instead of lists? ISTM that a list-based solution would be more usable than returning a starmap() object or somesuch. I suspect almost every user would have to call

[issue34632] Port importlib_metadata to Python 3.8

Jason R. Coombs added the comment: I believe buildbots are fixed. Please re-open if you find otherwise. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34632] Port importlib_metadata to Python 3.8

Jason R. Coombs added the comment: New changeset f7fba6cfb62edfc22e9b2e12a00ebaf5f348398e by Jason R. Coombs in branch 'master': bpo-34632 fix buildbots and remove artifact (GH-13566) https://github.com/python/cpython/commit/f7fba6cfb62edfc22e9b2e12a00ebaf5f348398e --

[issue34632] Port importlib_metadata to Python 3.8

Jason R. Coombs added the comment: > By the way, I think Python.framework is not needed? Correct. That was an artifact that I unintentionally added. I've submitted https://github.com/python/cpython/pull/13566 to address the two concerns. I've also opened issue37043 and issue37044 to

[issue34632] Port importlib_metadata to Python 3.8

Change by Jason R. Coombs : -- pull_requests: +13476 pull_request: https://github.com/python/cpython/pull/13566 ___ Python tracker ___

[issue34632] Port importlib_metadata to Python 3.8

Chih-Hsuan Yen added the comment: I managed to create a setup similar to the buildbot builder "AMD64 Fedora Rawhide Clang Installed 3.x" [1] on Arch Linux. Running test_importlib on an installed CPython copy is fine now: $ /usr/bin/python3.8 -m test.regrtest test_importlib Run tests

[issue34632] Port importlib_metadata to Python 3.8

Change by Chih-Hsuan Yen : -- pull_requests: +13475 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/13565 ___ Python tracker ___

[issue34632] Port importlib_metadata to Python 3.8

Chih-Hsuan Yen added the comment: By the way, I think Python.framework is not needed? https://github.com/python/cpython/commit/1bbf7b661f0ac8aac12d5531928d9a85c98ec1a9#diff-206dc381e448d5121da9a6040a2b13c1 -- ___ Python tracker

[issue34632] Port importlib_metadata to Python 3.8

Chih-Hsuan Yen added the comment: Oops apparently my fix is incomplete. From the builder "AMD64 Fedora Rawhide Clang Installed 3.x" [1]: ModuleNotFoundError: No module named 'test.test_importlib.data' [1] https://buildbot.python.org/all/api/v2/logs/824407/raw --

[issue34632] Port importlib_metadata to Python 3.8

Jason R. Coombs added the comment: New changeset c3738cfe63b1f2c1dc4a28d0ff9adb4e9e3aae1f by Jason R. Coombs (Chih-Hsuan Yen) in branch 'master': bpo-34632: fix installation of importlib.metadata (#13563) https://github.com/python/cpython/commit/c3738cfe63b1f2c1dc4a28d0ff9adb4e9e3aae1f

[issue34632] Port importlib_metadata to Python 3.8

Jason R. Coombs added the comment: I started trying to replicate the failure. I got as far as this Dockerfile: ``` FROM fedora:rawhide RUN yum install -y clang make git RUN git clone https://github.com/python/cpython WORKDIR cpython RUN ./configure RUN make ``` And then running `./python

[issue34632] Port importlib_metadata to Python 3.8

Chih-Hsuan Yen added the comment: I got the same ModuleNotFoundError on Arch Linux and https://github.com/python/cpython/pull/13563 fixes it. I believe it can fix the issue on Fedora buildbots, too. -- nosy: +yan12125 ___ Python tracker

[issue34632] Port importlib_metadata to Python 3.8

Change by Chih-Hsuan Yen : -- pull_requests: +13474 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/13563 ___ Python tracker ___

[issue34632] Port importlib_metadata to Python 3.8

STINNER Victor added the comment: Unhappy buildbot: AMD64 Fedora Rawhide Clang Installed 3.x https://buildbot.python.org/all/#/builders/188/builds/302 Example: 0:00:28 load avg: 4.02 [182/422/1] test_importlib failed Failed to import test module: test.test_importlib.test_main Traceback

[issue34632] Port importlib_metadata to Python 3.8

Barry A. Warsaw added the comment: New changeset 1bbf7b661f0ac8aac12d5531928d9a85c98ec1a9 by Barry Warsaw (Jason R. Coombs) in branch 'master': bpo-34632: Add importlib.metadata (GH-12547) https://github.com/python/cpython/commit/1bbf7b661f0ac8aac12d5531928d9a85c98ec1a9 --

[issue34632] Port importlib_metadata to Python 3.8

Barry A. Warsaw added the comment: Thanks @jaraco! This is now merged into 3.8. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34632] Port importlib_metadata to Python 3.8

Change by Jason R. Coombs : -- pull_requests: +12496 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34632] Port importlib_metadata to Python 3.8

Change by Barry A. Warsaw : -- keywords: +patch pull_requests: +8750 stage: -> patch review ___ Python tracker ___ ___

[issue34632] Port importlib_metadata to Python 3.8

New submission from Barry A. Warsaw : https://importlib_metadata.rtfd.org We're fleshing out the API and implementation in the standalone library, but once we're confident of the API and semantics, we will want to port this into Python 3.8. -- assignee: barry components: Library