[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Change by Eric Engeström : -- nosy: +1ace ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Change by Paulo Henrique Silva : -- nosy: +phsilva ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Change by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Nick Coghlan added the comment: python-dev thread with more discussion of the patch: https://mail.python.org/pipermail/python-dev/2018-September/155188.html Note that my comment above was based on a misunderstanding of what the patch does - the module level code still gets executed at

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Nick Coghlan added the comment: Something else this would need is a different name that better distinguishes it from the existing frozen modules, which freeze the bytecode rather than the resulting module state. (That existing approach avoids the stat overhead, but still incurs the module

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Neil Schemenauer added the comment: I commented on python-dev but maybe it is better to keep discussion here. Could we make the frozenmodules thing into a dynamically loaded module? Then you could have support for end users making their own. E.g. a command-line param that lists a set of

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Larry Hastings added the comment: As Neil points out on python-dev, my "improvement" should have been multiplied by 100, like 20.924239043734505 % instead of 0.20924239043734505 %, etc. -- ___ Python tracker

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Larry Hastings added the comment: I should add that there were two novel test failures in the regression test suite: test_module and test_site. -- ___ Python tracker ___

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Change by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Change by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

Change by Larry Hastings : -- keywords: +patch pull_requests: +8745 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue34690] Store startup modules as C structures for 20%+ startup speed improvement

New submission from Larry Hastings : This patch was sent to me privately by Jeethu Rao at Facebook. It's a change they're working with internally to improve startup time. What I've been told by Carl Shapiro at Facebook is that we have their blessing to post it publicly / merge it / build