[issue34738] Distutils: ZIP files don't include directory entries

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34738] Distutils: ZIP files don't include directory entries

Serhiy Storchaka added the comment: New changeset b2742ba5f9ce8a6108202e0645662f2b58da423b by Serhiy Storchaka in branch '2.7': [2.7] bpo-34738: Add directory entries in ZIP files created by distutils. (GH-9419). (GH-10950)

[issue34738] Distutils: ZIP files don't include directory entries

Serhiy Storchaka added the comment: New changeset e0c2046d82f6db45a7f3d3ee5f555c3e2487a74d by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-34738: Add directory entries in ZIP files created by distutils. (GH-9419) (GH-10942)

[issue34738] Distutils: ZIP files don't include directory entries

Change by Serhiy Storchaka : -- pull_requests: +10200 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34738] Distutils: ZIP files don't include directory entries

miss-islington added the comment: New changeset 53bed18d93233b030bb5b2637daf1b5e87548ef1 by Miss Islington (bot) in branch '3.7': bpo-34738: Add directory entries in ZIP files created by distutils. (GH-9419) https://github.com/python/cpython/commit/53bed18d93233b030bb5b2637daf1b5e87548ef1

[issue34738] Distutils: ZIP files don't include directory entries

Change by miss-islington : -- pull_requests: +10193 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34738] Distutils: ZIP files don't include directory entries

Change by miss-islington : -- pull_requests: +10194 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34738] Distutils: ZIP files don't include directory entries

Serhiy Storchaka added the comment: New changeset 67a93b3a0b3814e97ef9d077b21325fc8ce351b2 by Serhiy Storchaka in branch 'master': bpo-34738: Add directory entries in ZIP files created by distutils. (GH-9419) https://github.com/python/cpython/commit/67a93b3a0b3814e97ef9d077b21325fc8ce351b2

[issue34738] Distutils: ZIP files don't include directory entries

Serhiy Storchaka added the comment: The inconsistency is not just with the tarfile module, but with other method of creating ZIP archives. The unix unzip command creates directories if needed, but I am not sure about other third-party utilities. Since all know ZIP creators creates entries

[issue34738] Distutils: ZIP files don't include directory entries

Éric Araujo added the comment: IMO inconsistency with tarfile is not very relevant. About the zip utility: are you saying that the unix unzip command is not able to inspect or extract distutils sdists? About zipimport, the question is: are sdists meant to be directly importable (IMO no).

[issue34738] Distutils: ZIP files don't include directory entries

Serhiy Storchaka added the comment: There are two problems: 1. This is inconsistent with TAR files and the zip utility. 2. This is not compatible with zipimport. -- ___ Python tracker

[issue34738] Distutils: ZIP files don't include directory entries

Matthew Barnett added the comment: I don't see a problem with this. If the zip file has 'dist/file1.py' then you know to create a directory when unzipping. If you want to indicate that there's an empty directory 'foo', then put 'foo/' in the zip file. -- nosy: +mrabarnett

[issue34738] Distutils: ZIP files don't include directory entries

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +8839 stage: -> patch review ___ Python tracker ___ ___

[issue34738] Distutils: ZIP files don't include directory entries

New submission from Serhiy Storchaka : ZIP files created by distutils don't include entries for directories. For example, if the directory structure is dist/ file1.py sub/ file2.py the ZIP file will contain entries 'dist/file1.py' and 'dist/sub/file2.py', but