[issue34819] Executor.map and as_completed timeouts are able to deviate

miss-islington added the comment: New changeset 2b01121fd4200f1c27873422f7f72d02eec08630 by Miss Islington (bot) in branch '3.7': bpo-34819: Use a monotonic clock to compute timeouts in concurrent.futures (GH-9599)

[issue34819] Executor.map and as_completed timeouts are able to deviate

Change by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34819] Executor.map and as_completed timeouts are able to deviate

orlnub123 added the comment: Happy to help! I'm surprised it got merged so quickly, amazing response times all-around. -- ___ Python tracker ___

[issue34819] Executor.map and as_completed timeouts are able to deviate

miss-islington added the comment: New changeset 3a4aa6ac55e04c42757443d5b5854b6d893e0461 by Miss Islington (bot) in branch '3.6': bpo-34819: Use a monotonic clock to compute timeouts in concurrent.futures (GH-9599)

[issue34819] Executor.map and as_completed timeouts are able to deviate

STINNER Victor added the comment: Oh, I missed the Lib/concurrent/futures/ directory when I tried to patch the whole stdlib to use monotonic clocks for timeouts :-( Thanks for the fix! -- ___ Python tracker

[issue34819] Executor.map and as_completed timeouts are able to deviate

Change by miss-islington : -- pull_requests: +9000 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34819] Executor.map and as_completed timeouts are able to deviate

Change by miss-islington : -- pull_requests: +9001 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34819] Executor.map and as_completed timeouts are able to deviate

Antoine Pitrou added the comment: New changeset a94ee12c26aa8dd7dce01373779df8055aff765b by Antoine Pitrou (orlnub123) in branch 'master': bpo-34819: Use a monotonic clock to compute timeouts in concurrent.futures (GH-9599)

[issue34819] Executor.map and as_completed timeouts are able to deviate

Karthikeyan Singaravelan added the comment: Sorry, please ignore the comment reference to https://bugs.python.org/issue29733#msg289116 . I misunderstood that it was about concurrent.futures using time.time but it turns out it was about the program using time.time as verifying the PR against

[issue34819] Executor.map and as_completed timeouts are able to deviate

Karthikeyan Singaravelan added the comment: Thanks for the report and PR. I can find a very similar issue where time.time was changed to time.monotonic across multiprocessing module by Victor for the same reason : issue34054. I don't know why it wasn't changed in concurrent.futures . Seems

[issue34819] Executor.map and as_completed timeouts are able to deviate

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34819] Executor.map and as_completed timeouts are able to deviate

Change by orlnub123 : -- keywords: +patch pull_requests: +8996 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34819] Executor.map and as_completed timeouts are able to deviate

New submission from orlnub123 : The map and as_completed functions can randomly timeout earlier or later due to NTP stepping the clock or something changing the time and/or date. Here's some code to reproduce the issue for map: import concurrent.futures import time with