[issue34921] NoReturn not allowed by get_type_hints when future import annotations is used

Ivan Levkivskyi added the comment: New changeset f71a5922916abd6cc7bf7d99ed4715b6e96e5981 by Ivan Levkivskyi (Ismo Toijala) in branch '3.7': bpo-34921: Allow escaped NoReturn in get_type_hints (GH-9750) (GH-10772)

[issue34921] NoReturn not allowed by get_type_hints when future import annotations is used

Change by Ismo Toijala : -- pull_requests: +10016 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34921] NoReturn not allowed by get_type_hints when future import annotations is used

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34921] NoReturn not allowed by get_type_hints when future import annotations is used

Ivan Levkivskyi added the comment: New changeset 5eea0ad50c32d38909ff4e29309e2cc3c6ccb2c0 by Ivan Levkivskyi (Noah Wood) in branch 'master': bpo-34921: Allow escaped NoReturn in get_type_hints (GH-9750) https://github.com/python/cpython/commit/5eea0ad50c32d38909ff4e29309e2cc3c6ccb2c0

[issue34921] NoReturn not allowed by get_type_hints when future import annotations is used

noah added the comment: Is this a feature request? Because it doesn't look like a bug to me. Where NoReturn is defined it says it's supposed to fail in static type checkers. Anyway, I'm not entirely sure on the whole process of contributing but here goes: The code ultimately fails at

[issue34921] NoReturn not allowed by get_type_hints when future import annotations is used

Change by noah : -- keywords: +patch pull_requests: +9136 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34921] NoReturn not allowed by get_type_hints when future import annotations is used

Karthikeyan Singaravelan added the comment: Thanks for the report. I am adding Ivan who might have a better explanation since this is related to typing and type(NoReturn) has with __future__ import and without __future__. Ivan, feel free to remove yourself if this irrelevant. --

[issue34921] NoReturn not allowed by get_type_hints when future import annotations is used

New submission from Ismo Toijala : The following example should work but does not. Note that it does work without the future import. from __future__ import annotations import typing def f() -> typing.NoReturn: pass typing.get_type_hints(f) Traceback (most recent call last): File