[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

STINNER Victor added the comment: It seems like the issue has been fixed. See also bpo-35998 for a similar issue on other platforms. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Ned Deily added the comment: New changeset c101d1a88a8e0b0cec479307b4e0ae6866958a49 by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-35031: also disable TLS 1.3 for test_start_tls_server_1 on macOS (GH-14188) (GH-14192)

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

miss-islington added the comment: New changeset f49c85d0cb098ba75191a9e272d149ed6466dfb7 by Miss Islington (bot) in branch '3.8': bpo-35031: also disable TLS 1.3 for test_start_tls_server_1 on macOS (GH-14188) https://github.com/python/cpython/commit/f49c85d0cb098ba75191a9e272d149ed6466dfb7

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Change by miss-islington : -- pull_requests: +14029 pull_request: https://github.com/python/cpython/pull/14192 ___ Python tracker ___

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Ned Deily added the comment: New changeset a514f782b822bd7bca7c8d78be7bd53bc25c1908 by Ned Deily in branch 'master': bpo-35031: also disable TLS 1.3 for test_start_tls_server_1 on macOS (GH-14188) https://github.com/python/cpython/commit/a514f782b822bd7bca7c8d78be7bd53bc25c1908 --

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Change by miss-islington : -- pull_requests: +14028 pull_request: https://github.com/python/cpython/pull/14191 ___ Python tracker ___

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Change by Ned Deily : -- pull_requests: +14025 pull_request: https://github.com/python/cpython/pull/14188 ___ Python tracker ___

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

miss-islington added the comment: New changeset a5ddbfbf50715e3d4b90ad367ed6827c6cbcc52f by Miss Islington (bot) in branch '3.8': bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() (GH-14148) https://github.com/python/cpython/commit/a5ddbfbf50715e3d4b90ad367ed6827c6cbcc52f

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Change by miss-islington : -- pull_requests: +13991 pull_request: https://github.com/python/cpython/pull/14150 ___ Python tracker ___

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

STINNER Victor added the comment: New changeset c034b7824f5a7c50f2946ab3931633200e31d903 by Victor Stinner in branch 'master': bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() (GH-14148) https://github.com/python/cpython/commit/c034b7824f5a7c50f2946ab3931633200e31d903

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

miss-islington added the comment: New changeset 0040903bbae043225499babae23649d896ea2eec by Miss Islington (bot) in branch '3.7': bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() (GH-14148) https://github.com/python/cpython/commit/0040903bbae043225499babae23649d896ea2eec

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Change by miss-islington : -- pull_requests: +13993 pull_request: https://github.com/python/cpython/pull/14151 ___ Python tracker ___

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

STINNER Victor added the comment: Commit f6a47f3e316cede2a07a1f74a509f6d80ab8fef0 introduced a workaround on Windows and FreeBSD. It was removed by commit f0749da9a535375f05a2015e8960e8ae54877349 in bpo-35998... but then Windows restarted to fail:

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Change by STINNER Victor : -- pull_requests: +13989 pull_request: https://github.com/python/cpython/pull/14148 ___ Python tracker ___

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Open Close added the comment: Am I wrong with something? But test_start_tls_server_1 in newly made cpython fails on my plain intel linux personal PC. If I comment out the FreeBSD conditional (to apply ssl.OP_NO_TLSv1_3), the test passes. If I change HELLO_MSG to 1*1024*1024 (msg328157),

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Change by Open Close : -- nosy: +op368 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Ned Deily added the comment: If the failure has regularly shown up on 3.6 FreeBSD buildbots in the past, I would accept a backport of the test change to 3.6. -- nosy: +ned.deily ___ Python tracker

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Pablo Galindo Salgado added the comment: I think is missing a manual backport to 3.6, but now that we are in security fixes only I am not sure of what to do. -- ___ Python tracker

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Terry J. Reedy added the comment: should this be closed? -- nosy: +terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

miss-islington added the comment: New changeset 3f9fe53c98978955fea4e36456c784694e6458a8 by Miss Islington (bot) in branch '3.7': bpo-35031: Fix test_start_tls_server_1 on FreeBSD buildbots (GH-10011) https://github.com/python/cpython/commit/3f9fe53c98978955fea4e36456c784694e6458a8

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Change by miss-islington : -- pull_requests: +9757 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Pablo Galindo Salgado added the comment: New changeset f6a47f3e316cede2a07a1f74a509f6d80ab8fef0 by Pablo Galindo in branch 'master': bpo-35031: Fix test_start_tls_server_1 on FreeBSD buildbots (GH-10011) https://github.com/python/cpython/commit/f6a47f3e316cede2a07a1f74a509f6d80ab8fef0

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Pablo Galindo Salgado added the comment: > note: Roundup sent me comments as email notifications in the backward order, > that's funny to see Pablo's answer before my question :-) Maybe I just answered faster than the speed of light ;) -- ___

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

STINNER Victor added the comment: note: Roundup sent me comments as email notifications in the backward order, that's funny to see Pablo's answer before my question :-) -- ___ Python tracker

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Pablo Galindo Salgado added the comment: Someone needs to review PR10011 -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

STINNER Victor added the comment: Any progress on this issue? It's still failing: https://buildbot.python.org/all/#/builders/168/builds/143 -- nosy: +vstinner ___ Python tracker

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Change by STINNER Victor : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +9351 stage: -> patch review ___ Python tracker ___ ___

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Pablo Galindo Salgado added the comment: Re-adding client_context.options |= ssl.OP_NO_TLSv1_3 makes the test pass again. -- ___ Python tracker ___

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Pablo Galindo Salgado added the comment: It seems that the problem is that the ServerProto of test_start_tls_server_1 never receives a call to eof_received(). Weirdly enough it seems that if the HELLO_MSG is large enough (1024 * 1024), then the test always succeed. If we deactivate tls in

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Pablo Galindo Salgado added the comment: Building and testing the parent of dbf102271fcc316f353c7e0a283811b661d128f2 always succeeds. -- ___ Python tracker ___

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Pablo Galindo Salgado added the comment: I think something is going on with the buildbot itself or the test has some race condition because that commit has been built before multiple times with no error. I am investigating in the buildbot itself. --

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Pablo Galindo Salgado added the comment: Bisecting points to commit dbf102271fcc316f353c7e0a283811b661d128f2 as the dirst bad commit: dbf102271fcc316f353c7e0a283811b661d128f2 is the first bad commit commit dbf102271fcc316f353c7e0a283811b661d128f2 Author: Yury Selivanov Date: Mon May 28

[issue35031] test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots

Change by Pablo Galindo Salgado : -- title: test_asyncio test_start_tls_server_1 fails in -> test_asyncio test_start_tls_server_1 fails in AMD64 FreeBSD CURRENT buildbots ___ Python tracker