[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35081] Move internal headers to Include/internal/

Eric Snow added the comment: On Fri, Oct 15, 2021 at 3:56 AM STINNER Victor wrote: > New changeset 063abd931f064a4b6b478b0b6e9aa13ee38d2cff by Victor Stinner in > branch 'main': > bpo-35081: Move interpreteridobject.h to Include/internal/ (GH-28969) FYI, _xxsubinterpretersmodule is supposed

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 063abd931f064a4b6b478b0b6e9aa13ee38d2cff by Victor Stinner in branch 'main': bpo-35081: Move interpreteridobject.h to Include/internal/ (GH-28969) https://github.com/python/cpython/commit/063abd931f064a4b6b478b0b6e9aa13ee38d2cff --

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: I reopen the issue since there is still activity on it. -- resolution: fixed -> status: closed -> open ___ Python tracker ___

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +27257 pull_request: https://github.com/python/cpython/pull/28969 ___ Python tracker ___

[issue35081] Move internal headers to Include/internal/

Change by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset e9e7d284c434768333fdfb53a3663eae74cb995a by Victor Stinner in branch 'master': bpo-35081: Move dtoa.h header to the internal C API (GH-18489) https://github.com/python/cpython/commit/e9e7d284c434768333fdfb53a3663eae74cb995a --

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 45876a90e2663f12b90c2090ec3e48bd97841aae by Victor Stinner in branch 'master': bpo-35081: Move bytes_methods.h to the internal C API (GH-18492) https://github.com/python/cpython/commit/45876a90e2663f12b90c2090ec3e48bd97841aae --

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +17865 pull_request: https://github.com/python/cpython/pull/18492 ___ Python tracker ___

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +17862 pull_request: https://github.com/python/cpython/pull/18489 ___ Python tracker ___

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +13937 pull_request: https://github.com/python/cpython/pull/13890 ___ Python tracker ___

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset ec13b9322d95a651606219469fc7b7e9c977f248 by Victor Stinner in branch 'master': bpo-35081: Add Include/internal/pycore_tupleobject.h (GH-10705) https://github.com/python/cpython/commit/ec13b9322d95a651606219469fc7b7e9c977f248 --

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9956 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 8ac6539d85b481fc6b5e9145446b07e591b2caba by Victor Stinner in branch 'master': bpo-35081: Add _PyTuple_CAST() (GH-10704) https://github.com/python/cpython/commit/8ac6539d85b481fc6b5e9145446b07e591b2caba --

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9955 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: In bpo-35296, I modified "make install" to also install Include/internal/. -- ___ Python tracker ___

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: I close the issue, it seems like all sub-tasks have been completed! Summary of the change: * Header files of Include/internal/ are now all prefixed by "pycore_" and the directory has been added to the header search path. For example, #include

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 4ac5328affa37bdfc5847dfdb2a41bad772e7270 by Victor Stinner in branch 'master': bpo-35081: add NEWS entry for new Include/internal/pycore_*.h files (GH-10666) https://github.com/python/cpython/commit/4ac5328affa37bdfc5847dfdb2a41bad772e7270

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 984061eeb49c54fee901b92e5d3dde1c7a25cfa1 by Victor Stinner in branch 'master': bpo-35081: Add new internal headers to Makefile (GH-10670) https://github.com/python/cpython/commit/984061eeb49c54fee901b92e5d3dde1c7a25cfa1 --

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9924 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9919 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset bcda8f1d42a98d9022736dd52d855be8e220fe15 by Victor Stinner in branch 'master': bpo-35081: Add Include/internal/pycore_object.h (GH-10640) https://github.com/python/cpython/commit/bcda8f1d42a98d9022736dd52d855be8e220fe15 --

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9888, 9889 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9888 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9888, 9889, 9890 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: Please review PR 10624 of bpo-35134: Create Include/unstable/ subdirectory. It's the second part of my plan :-) -- ___ Python tracker ___

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 3e21ad1a254cc33e8d4920ad7f026254ec728bee by Victor Stinner in branch 'master': bpo-35081: Move _PyGC_FINALIZED() back to C API (GH-10626) https://github.com/python/cpython/commit/3e21ad1a254cc33e8d4920ad7f026254ec728bee --

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: Stefan Behnel: > Making _PyGC_FINALIZED() internal broke Cython > (https://github.com/cython/cython/issues/2721). It's used in the finaliser > implementation >

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9874 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: TODO: add a NEWS entry for all these changes. Copy of Nick Coghlan's comment: https://github.com/python/cpython/pull/10275#issuecomment-439339982 @vstinner For folks consuming source archives (Linux distros, anyone embedding Python in a larger application,

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: > Making _PyGC_FINALIZED() internal broke Cython (...) Aha, interesting. Would you mind to open a new dedicated issue? So we can discuss how much of the GC details we want to leak into the API :-) -- ___ Python

[issue35081] Move internal headers to Include/internal/

Stefan Behnel added the comment: Making _PyGC_FINALIZED() internal broke Cython (https://github.com/cython/cython/issues/2721). It's used in the finaliser implementation

[issue35081] Move internal headers to Include/internal/

Alexey Izbyshev added the comment: > Oh, I never saw this warning before. It seems to not be included in -Wall. > Would you mind to open a new issue to discuss it? Victor, I've opened #35258 as you suggested. -- ___ Python tracker

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 1a6be91e6fd65ce9cb88c193db7e92ec6076 by Victor Stinner in branch 'master': bpo-35081: Make some _PyGC macros internal (GH-10507) https://github.com/python/cpython/commit/1a6be91e6fd65ce9cb88c193db7e92ec6076 --

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: Hum, this issue is much harder than what I expected. Status: * Include/internal/ header files have been renamed to get a new "pycore_" prefix which avoids conflicts with Include/ header files. Example: "pycore_pystate.h" vs "pystate.h". * pyatomic.c has

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9767 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: Status: only pyport. and tupleobject.h use Py_BUILD_CORE, and only tupleobject.h uses "#ifdef Py_BUILD_CORE" (contains code specific to internals). $ grep Py_BUILD_CORE Include/*.h Include/pyport.h:# if defined(Py_BUILD_CORE) ||

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 0d12672b30b8c6c992bef7564581117ae83e11ad by Victor Stinner (Paul Ganssle) in branch 'master': bpo-35081: Remove Py_BUILD_CORE from datetime.h (GH-10416) https://github.com/python/cpython/commit/0d12672b30b8c6c992bef7564581117ae83e11ad

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 621cebe81b1e6c8de10425955bf532d31ee4df42 by Victor Stinner in branch 'master': bpo-35081: Rename internal headers (GH-10275) https://github.com/python/cpython/commit/621cebe81b1e6c8de10425955bf532d31ee4df42 --

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: > Python/pystate.c:968:1: warning: no previous prototype for ‘_PyGILState_Init’ > [-Wmissing-prototypes] _PyGILState_Init(PyInterpreterState *i, PyThreadState *t) ^~~~ Oh, I never saw this warning before. It seems to not be included in -Wall.

[issue35081] Move internal headers to Include/internal/

Alexey Izbyshev added the comment: Victor, you moved declarations of some functions to other headers, but didn't include the new headers into files that implement the functions in some cases. For example, _PyGILState_Init was moved into Include/internal/pycore_lifecycle.h in

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 130893debfd97c70e3a89d9ba49892f53e6b9d79 by Victor Stinner in branch 'master': bpo-35081: Internal headers require Py_BUILD_CORE (GH-10363) https://github.com/python/cpython/commit/130893debfd97c70e3a89d9ba49892f53e6b9d79 --

[issue35081] Move internal headers to Include/internal/

Change by Paul Ganssle : -- pull_requests: +9696 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 9fc57a384825530635ef5ec093a31d864ea14f7c by Victor Stinner in branch 'master': bpo-35081: Add pycore_fileutils.h (GH-10371) https://github.com/python/cpython/commit/9fc57a384825530635ef5ec093a31d864ea14f7c --

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9672 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9664 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset 5ed6995675b084fe583b71f96fdde4413bb2a77b by Victor Stinner in branch 'master': bpo-35081: Add _PyCoreConfig_AsDict() (GH-10362) https://github.com/python/cpython/commit/5ed6995675b084fe583b71f96fdde4413bb2a77b --

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9662 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: > Please don't change Include/datetime.h without consulting with original > authors of this code (see issue876130). FYI I tried to be very careful on each change to never modify the *public* C API. But I modified the Py_BUILD_CORE API. This is fine since

[issue35081] Move internal headers to Include/internal/

Serhiy Storchaka added the comment: Please don't change Include/datetime.h without consulting with original authors of this code (see issue876130). -- nosy: +atuining, lemburg, serhiy.storchaka, tim.peters ___ Python tracker

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: I created bpo-35134: Move !Py_LIMITED_API to Include/pycapi/. -- ___ Python tracker ___ ___

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9588 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9587 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9586 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: > bpo-35081: And pycore_lifecycle.h and pycore_pathconfig.h (GH-10273) I tried to add the Py_BUILD_CORE guard in pycore_pathconfig.h: +#ifndef Py_BUILD_CORE +# error "Py_BUILD_CORE must be defined to include this header" +#endif But it breaks the

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9585 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

STINNER Victor added the comment: New changeset a1c249c40517917d2e0971d55aea8d14a44b2cc8 by Victor Stinner in branch 'master': bpo-35081: And pycore_lifecycle.h and pycore_pathconfig.h (GH-10273) https://github.com/python/cpython/commit/a1c249c40517917d2e0971d55aea8d14a44b2cc8 --

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- pull_requests: +9584 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35081] Move internal headers to Include/internal/

Change by STINNER Victor : -- title: Rename Include/internals/ to Include/pycore/ -> Move internal headers to Include/internal/ ___ Python tracker ___