[issue35090] Potential division by zero and integer overflow in allocator wrappers

STINNER Victor added the comment: Ok, now we should be good :-) I close again the issue. Note: Serhiy Stochaka considers that no NEWS entry is needed and I concur with him. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue35090] Potential division by zero and integer overflow in allocator wrappers

miss-islington added the comment: New changeset fd0a3bce6e917b5853c809a309c1513acc176f56 by Miss Islington (bot) in branch '3.6': bpo-35090: Fix potential division by zero in allocator wrappers (GH-10174) https://github.com/python/cpython/commit/fd0a3bce6e917b5853c809a309c1513acc176f56

[issue35090] Potential division by zero and integer overflow in allocator wrappers

miss-islington added the comment: New changeset 1d7d165e3c3f07518e6b5bfb57f1fd460cd4bbf2 by Miss Islington (bot) in branch '3.7': bpo-35090: Fix potential division by zero in allocator wrappers (GH-10174) https://github.com/python/cpython/commit/1d7d165e3c3f07518e6b5bfb57f1fd460cd4bbf2

[issue35090] Potential division by zero and integer overflow in allocator wrappers

STINNER Victor added the comment: Serhiy: "I think it is worth to backport." Ok. I asked the bot to create 3.6 and 3.7 backports, and I just approved them. I checked: Python 2.7 is not affected. -- versions: +Python 3.6, Python 3.7 ___ Python

[issue35090] Potential division by zero and integer overflow in allocator wrappers

Change by miss-islington : -- pull_requests: +9514 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue35090] Potential division by zero and integer overflow in allocator wrappers

Change by miss-islington : -- pull_requests: +9515 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35090] Potential division by zero and integer overflow in allocator wrappers

Change by STINNER Victor : -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35090] Potential division by zero and integer overflow in allocator wrappers

Serhiy Storchaka added the comment: I think it is worth to backport. Perhaps it is possible even to create a reproducer for integer overflow, but I afraid it will be too slow for using in tests. -- ___ Python tracker

[issue35090] Potential division by zero and integer overflow in allocator wrappers

STINNER Victor added the comment: > Regarding backporting, what about integer overflow? Do you think it's > guaranteed that the multiple of items and size always fits in 32-bit types, > in case of BZ2_Malloc and PyZlib_Malloc? I don't know. Serhiy: What do you think? --

[issue35090] Potential division by zero and integer overflow in allocator wrappers

Alexey Izbyshev added the comment: Sorry for changing the status, it's browser caching again. -- resolution: -> fixed status: open -> closed versions: -Python 3.6, Python 3.7 ___ Python tracker

[issue35090] Potential division by zero and integer overflow in allocator wrappers

Alexey Izbyshev added the comment: Thanks, Victor. Regarding backporting, what about integer overflow? Do you think it's guaranteed that the multiple of items and size always fits in 32-bit types, in case of BZ2_Malloc and PyZlib_Malloc? -- resolution: fixed -> status: closed ->

[issue35090] Potential division by zero and integer overflow in allocator wrappers

STINNER Victor added the comment: I don't want to backport this change. IMHO these wrappers are never called with 0. Otherwise, I'm sure that someone would report the crash... But I applied the change anyway, just to avoid future reports of static analyzers :-) And the cast doesn't hurt :-)

[issue35090] Potential division by zero and integer overflow in allocator wrappers

STINNER Victor added the comment: New changeset 3d4fabb2a424cb04ae446ebe4428090c386f45a5 by Victor Stinner (Alexey Izbyshev) in branch 'master': bpo-35090: Fix potential division by zero in allocator wrappers (GH-10174)

[issue35090] Potential division by zero and integer overflow in allocator wrappers

Change by Alexey Izbyshev : -- title: bz2: Potential division by zero in BZ2_Malloc() -> Potential division by zero and integer overflow in allocator wrappers ___ Python tracker