[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Géry added the comment: Thanks @barry for reviewing and merging PR 15190 > I haven't merged PR 10016, but I left some additional comments. Are you > still interested in shepherding this PR? Also thanks for helping me with @ericsnowcurrently advancing this last PR. Yes I am still

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Barry A. Warsaw added the comment: @maggyero - I haven't merged PR 10016, but I left some additional comments. Are you still interested in shepherding this PR? -- ___ Python tracker

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

miss-islington added the comment: New changeset 6e842bcdf8a47fe081c9f2edc2b8875e1f3e2f18 by Miss Skeleton (bot) in branch '3.9': bpo-35181: Correct importlib documentation for some module attributes (GH-15190) https://github.com/python/cpython/commit/6e842bcdf8a47fe081c9f2edc2b8875e1f3e2f18

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

miss-islington added the comment: New changeset 916ac9520108831d2099b13992a45884b112b193 by Miss Skeleton (bot) in branch '3.8': bpo-35181: Correct importlib documentation for some module attributes (GH-15190) https://github.com/python/cpython/commit/916ac9520108831d2099b13992a45884b112b193

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Change by miss-islington : -- pull_requests: +21815 pull_request: https://github.com/python/cpython/pull/22873 ___ Python tracker ___

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Change by miss-islington : -- pull_requests: +21814 pull_request: https://github.com/python/cpython/pull/22872 ___ Python tracker ___

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

miss-islington added the comment: New changeset 27f1bd8787d24ac53cc3dc6ea5eb00b8a3499839 by Géry Ogam in branch 'master': bpo-35181: Correct importlib documentation for some module attributes (GH-15190) https://github.com/python/cpython/commit/27f1bd8787d24ac53cc3dc6ea5eb00b8a3499839

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Barry A. Warsaw added the comment: Apologies for the long delay in reviewing this bug. I'm looking at it now, however since Python 3.7 is in security-only mode, this will only apply to 3.10, 3.9, and 3.8. -- versions: +Python 3.10, Python 3.9 -Python 3.7

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Change by Géry : -- pull_requests: +14922 pull_request: https://github.com/python/cpython/pull/15190 ___ Python tracker ___ ___

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Géry added the comment: Oops, sorry, only one of the two PRs has been merged. -- ___ Python tracker ___ ___ Python-bugs-list

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Géry added the comment: @Julien, @Barry Now that the PRs are merged, I think that we can close this issue. -- ___ Python tracker ___

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Barry A. Warsaw added the comment: I've approved both PRs, however I am rather uncomfortable about the code snippet in import.rst. Géry's change is a good one AFAICT, and thanks for the contribution! I would feel much better about the long term correctness of this code snippet if we had a

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Change by Brett Cannon : -- assignee: docs@python -> barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Cheryl Sabella added the comment: @barry, you started a review of PR10016 and I believe all your requested changes have been made, so please review again when you get a chance. Please also take a look at PR10376. Thanks! -- nosy: +cheryl.sabella type: -> enhancement versions:

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Change by Géry : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Géry added the comment: It looks like Barry Warsaw has not been fully updated the documentation after making the __spec__.loader attribute match with the __loader__ attribute, and the __spec__.file attribute match with the __file__ attribute for namespace packages. Here is a pull request to

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Change by Géry : -- pull_requests: +9678 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Change by Géry : -- keywords: +patch pull_requests: +9677 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

Change by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35181] Doc: Namespace Packages: Inconsistent documentation of __loader__ being None

New submission from Julien Palard : The documentation states that a __loader__ of a namespace package should be None: - [1] "For namespace packages this should be set to None." - [2] "To indicate to the import machinery that the spec represents a namespace portion. the path entry finder sets