[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

miss-islington added the comment: New changeset 30fd7a476bbd6bb8096c1349698463fa8a3bca18 by Miss Islington (bot) in branch '3.7': closes bpo-35184: Fix XML_POOR_ENTROPY option that breaks makesetup parsing of pyexpat line in Setup. (GH-13064)

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

miss-islington added the comment: New changeset 5b94b857f590db80aab69c31f88dd2a4978f8329 by Miss Islington (bot) in branch '3.8': closes bpo-35184: Fix XML_POOR_ENTROPY option that breaks makesetup parsing of pyexpat line in Setup. (GH-13064)

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

Benjamin Peterson added the comment: New changeset 408a2ef1aceff1f4270c44552fa39ef93d9283e3 by Benjamin Peterson (aaronpaulhurst) in branch 'master': closes bpo-35184: Fix XML_POOR_ENTROPY option that breaks makesetup parsing of pyexpat line in Setup. (GH-13064)

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

Change by miss-islington : -- pull_requests: +13828 pull_request: https://github.com/python/cpython/pull/13961 ___ Python tracker ___

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

Change by miss-islington : -- pull_requests: +13827 pull_request: https://github.com/python/cpython/pull/13960 ___ Python tracker ___

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

Aaron Hurst added the comment: Hi Ned, Thanks for testing this. I also observe that macOS compiles "without error"... but it's still broken... and silently. This is because the pyexpat line isn't being turned into the expected set of source compilation rules, but it is instead being

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

Ned Deily added the comment: Thanks for the updates, Aaron. The plot thickens! If I perform the steps on a current macOS system, the result is: 273 pyexpat expat/xmlparse.c expat/xmlrole.c expat/xmltok.c pyexpat.c -I$(srcdir)/Modules/expat -DHAVE_EXPAT_CONFIG_H -DXML_POOR_ENTROPY=1

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

Aaron Hurst added the comment: Hi Ned, >From a fresh checkout of master on Ubuntu 18.04, I uncomment the pyexpat line >in Modules/Setup and run: cpython$ ./configure ... cpython$ make Makefile:273: *** missing separator. Stop. Here is the offending section of the resulting Makefile: 269

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

Aaron Hurst added the comment: Sorry for my misunderstanding of the process, and thanks for explaining. I resubmitted the PR against the master branch. -- ___ Python tracker

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

Change by Aaron Hurst : -- pull_requests: +12981 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

Ned Deily added the comment: Thanks for the report and thanks for the PR. I am confused here as I cannot reproduce the failure. Can someone show what is invalid in the Makefile? Also, if the change really does need to be made to Setup.dist (3.7) or Setup (master -> 3.8), then setup.py

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

Aaron Hurst added the comment: I can reproduce this issue by uncommenting the pyexpat line in Setup.dist and compiling. The issue is with -DXML_POOR_ENTROPY=1. The equals character causes the line to be incorrectly interpreted as a macro definition by makesetup. This results in an

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

Change by Aaron Hurst : -- keywords: +patch pull_requests: +12827 stage: -> patch review ___ Python tracker ___ ___

[issue35184] Makefile is not correctly generated when compiling pyextat with DXML_POOR_ENTROPY=1

New submission from Marta Gómez : Hello, I was getting this same error (https://bugs.python.org/issue35139) when compiling pyextat so I added these changes (https://github.com/python/cpython/pull/10291/files) to my Setup.dist. After running ./configure, the generated Makefile throws the