[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

STINNER Victor added the comment: I tested my 3.7 and master fixes: they fix test_c_locale_coercion on the FreeBSD CURRENT buildbot. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python

[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

STINNER Victor added the comment: New changeset f6e323ce322cf54b1a9e9252b13f93ebc28b5c24 by Victor Stinner in branch '3.7': bpo-34523: Fix C locale coercion on FreeBSD CURRENT (GH-10672) (GH-10673) https://github.com/python/cpython/commit/f6e323ce322cf54b1a9e9252b13f93ebc28b5c24 --

[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

Change by STINNER Victor : -- pull_requests: +9929 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

STINNER Victor added the comment: New changeset 353933e712b6c7f7ba9a9a50bd5bd472db7c35d0 by Victor Stinner in branch 'master': bpo-34523: Fix C locale coercion on FreeBSD CURRENT (GH-10672) https://github.com/python/cpython/commit/353933e712b6c7f7ba9a9a50bd5bd472db7c35d0 --

[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

STINNER Victor added the comment: The bug is that sys.getfilesystemencoding() should be the locale encoding. On FreeBSD CURRENT, Python uses ASCII for the filesystem encoding, whereas the locale encoding is UTF-8. CURRENT-amd64% env -i ./python -X utf8=0 -c 'import locale, sys;

[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

STINNER Victor added the comment: Oh, I also modified Python 3.7 to respect the "force ASCII" mode in bpo-34403, commit 21220bbe65108f5a763ead24a6b572f80d84c9e2. Hopefully, this change is not part of the latest Python 3.7.1 bugfix release. By the way, the bug only impacts FreeBSD CURRENT

[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

STINNER Victor added the comment: Ok, I found the bug: it is related to the commit 905f1ace5f7424e314ca7bed997868a2a3044839 of bpo-34523. Python now uses ASCII for the filesystem encoding if the internal "force ASCII" mode is enabled in Py_DecodeLocale/Py_EncodeLocale. FreeBSD CURRENT

[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

Change by STINNER Victor : -- pull_requests: +9927 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

STINNER Victor added the comment: > I'm wondering if we may need to make test_c_locale_coercion less opinionated, > where for most platforms it's just a "don't segfault" test, and it's only for > ones where we're certain about how we expect it to behave (i.e. Linux, Mac OS > X, AIX, maybe

[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

Change by Kubilay Kocak : -- nosy: +koobs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

Nick Coghlan added the comment: Ah, interesting. https://bugs.python.org/issue30672 covered the fact that this test was already weird on FreeBSD, but the current status is that it was expecting BSD variants to act somewhat like Mac OS X, not like Linux. I'm wondering if we may need to make

[issue35290] [FreeBSD] test_c_locale_coercion doesn't support new C.UTF-8 locale of FreeBSD CURRENT

STINNER Victor added the comment: More FreeBSD commits, "Teach man(1) about C.UTF-8": https://svnweb.freebsd.org/base?view=revision=340128 --- EXPECTED_C_LOCALE_STREAM_ENCODING = 'ascii' EXPECTED_C_LOCALE_FS_ENCODING = 'ascii' I guess that the problem comes from that. But I'm not sure of