[issue36025] Breaking change in PyDate_FromTimeStamp API

Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> behavior ___ Python tracker ___

[issue36025] Breaking change in PyDate_FromTimeStamp API

Berker Peksag added the comment: New changeset 4d8c8c0ad6163c24136d3419eb04f310b31f7e64 by Berker Peksag (Paul Ganssle) in branch 'master': bpo-36025: Fix PyDate_FromTimestamp API (GH-11922) https://github.com/python/cpython/commit/4d8c8c0ad6163c24136d3419eb04f310b31f7e64 -- nosy:

[issue36025] Breaking change in PyDate_FromTimeStamp API

Serhiy Storchaka added the comment: I prefer option 2. Your PR LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36025] Breaking change in PyDate_FromTimeStamp API

Paul Ganssle added the comment: I've put *a* fix in there by introducing a new wrapper function. Ideally we would just point the C API at the argument clinic-generated function, but because it takes a single positional argument the argument clinic outputs a METH_O function instead of

[issue36025] Breaking change in PyDate_FromTimeStamp API

Change by Paul Ganssle : -- keywords: +patch pull_requests: +11947 stage: -> patch review ___ Python tracker ___ ___

[issue36025] Breaking change in PyDate_FromTimeStamp API

New submission from Paul Ganssle : The PyO3 test suite has been breaking since the alpha release of Python 3.8 because PyDateTimeAPI->Date_FromTimeStamp has had a breaking change in its API: https://github.com/PyO3/pyo3/issues/352 I believe this happened when `datetime.date.fromtimestamp`