[issue36096] IDLE: Refactor class variables to instance variables in colorizer

2019-02-27 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36096] IDLE: Refactor class variables to instance variables in colorizer

2019-02-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 488aabafe2f1c5db05a6c1a7a8b49d7b89b1f36b by Terry Jan Reedy (Miss Islington (bot)) in branch '3.7': bpo-36096: IDLE: Refactor class variables in colorizer (GH-12002) (GH-12075)

[issue36096] IDLE: Refactor class variables to instance variables in colorizer

2019-02-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +12094 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36096] IDLE: Refactor class variables to instance variables in colorizer

2019-02-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +12089 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36096] IDLE: Refactor class variables to instance variables in colorizer

2019-02-27 Thread Cheryl Sabella
Cheryl Sabella added the comment: New changeset ed1deb0719f0ac1b08a374e30ad26a701d4d51a2 by Cheryl Sabella in branch 'master': bpo-36096: IDLE: Refactor class variables in colorizer (GH-12002) https://github.com/python/cpython/commit/ed1deb0719f0ac1b08a374e30ad26a701d4d51a2 --

[issue36096] IDLE: Refactor class variables to instance variables in colorizer

2019-02-23 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch pull_requests: +12033 stage: -> patch review ___ Python tracker ___ ___

[issue36096] IDLE: Refactor class variables to instance variables in colorizer

2019-02-23 Thread Cheryl Sabella
New submission from Cheryl Sabella : >From Terry's comment on PR11472 for issue 35689: > I don't like the use of class variables to initialize volatile instance state > variables. I think it confuses the code a bit. Better, I think, to put them > in an `init_state` method called from