[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

miss-islington added the comment: New changeset d9b25a2627ff6f4e10d46b4de4fff941b63497c7 by Miss Islington (bot) in branch '3.7': bpo-36235: Fix distutils test_customize_compiler() on macOS (GH-12764) https://github.com/python/cpython/commit/d9b25a2627ff6f4e10d46b4de4fff941b63497c7

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by miss-islington : -- pull_requests: +12697 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: New changeset a9bd8925c7fa50dd3cfab125b824ec192133ef49 by Victor Stinner in branch 'master': bpo-36235: Fix distutils test_customize_compiler() on macOS (GH-12764) https://github.com/python/cpython/commit/a9bd8925c7fa50dd3cfab125b824ec192133ef49 --

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: Good, my change fixed x86-64 High Sierra 2.7 buildbot: https://buildbot.python.org/all/#/builders/140/builds/216 I wrote PR 12764 to forward-port the fix to the master branch. -- ___ Python tracker

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by STINNER Victor : -- pull_requests: +12692 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: New changeset 22de4ce498b656063e236350e8404981c13e1cd8 by Victor Stinner in branch '2.7': bpo-36235: Fix distutils test_customize_compiler() on macOS (GH-12751) https://github.com/python/cpython/commit/22de4ce498b656063e236350e8404981c13e1cd8 --

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by STINNER Victor : -- pull_requests: +12678 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: Oh, the test failed on Python 2.7 on macOS: x86-64 High Sierra 2.7 https://buildbot.python.org/all/#/builders/140/builds/211 == FAIL: test_customize_compiler

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Chih-Hsuan Yen added the comment: Oh, I didn't know the bot is not working for now. Thank you for making the test more robust! -- ___ Python tracker ___

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: Thanks for the review, I merged my PR and the test enhancements. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: New changeset 8c380e99e9b71387d5722373805fe3159e2d912c by Victor Stinner in branch '2.7': bpo-36235: Enhance distutils test_customize_compiler() (GH-12403) (GH-12417) https://github.com/python/cpython/commit/8c380e99e9b71387d5722373805fe3159e2d912c

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: New changeset dd1cfefd67f254ce44f33995922e347c9d3f7b4e by Victor Stinner in branch '3.7': bpo-36235: Enhance distutils test_customize_compiler() (GH-12403) (GH-12415) https://github.com/python/cpython/commit/dd1cfefd67f254ce44f33995922e347c9d3f7b4e

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: > Just a question: I think it should be backported to 3.7 and 2.7 (...) Right, I wrote PRs for that. I didn't use GitHub labels because the bot is currently broken. -- ___ Python tracker

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by STINNER Victor : -- pull_requests: +12371 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by STINNER Victor : -- pull_requests: +12369 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: New changeset 72c7b372cf145fded93a9a776acc742a60090f95 by Victor Stinner in branch 'master': bpo-36235: Enhance distutils test_customize_compiler() (GH-12403) https://github.com/python/cpython/commit/72c7b372cf145fded93a9a776acc742a60090f95 --

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Chih-Hsuan Yen added the comment: STINNER Victor: Thank you very much for that much better fix! I've tested it on Arch Linux. With that patch, test_distutils passes as usual. The pull request looks good, too. Just a question: I think it should be backported to 3.7 and 2.7 branches like

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: Chih-Hsuan Yen: After this patch, test_distutils failed if $CPPFLAGS is not empty when building CPython. Aha, more sysconfig configuration variables and environment variables should be mocked. I wrote PR 12403 to mock all variables. Would you mind to test

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by STINNER Victor : -- pull_requests: +12358 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by Chih-Hsuan Yen : -- pull_requests: +12338 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Chih-Hsuan Yen added the comment: After this patch, test_distutils failed if $CPPFLAGS is not empty when building CPython. For example: $ export CPPFLAGS=-DFOO=BAR $ ./configure $ make $ ./python -m test test_distutils Run tests sequentially 0:00:00 load avg: 0.45 [1/1] test_distutils

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: New changeset 6c0e0d141a07cc3fd2441d9df8d762f56bf7edf2 by Victor Stinner in branch '3.7': bpo-36235: Fix CFLAGS in distutils customize_compiler() (GH-12236) (GH-12348) https://github.com/python/cpython/commit/6c0e0d141a07cc3fd2441d9df8d762f56bf7edf2

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: New changeset 37f6971777c05b5ca9c157606896b7ff458756a5 by Victor Stinner in branch '2.7': bpo-36235: Fix CFLAGS in distutils customize_compiler() (GH-12236) (GH-12349) https://github.com/python/cpython/commit/37f6971777c05b5ca9c157606896b7ff458756a5

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by STINNER Victor : -- pull_requests: +12315 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by STINNER Victor : -- pull_requests: +12314 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

STINNER Victor added the comment: New changeset 86082c22d23285995a32aabb491527c9f5629556 by Victor Stinner in branch 'master': bpo-36235: Fix CFLAGS in distutils customize_compiler() (GH-12236) https://github.com/python/cpython/commit/86082c22d23285995a32aabb491527c9f5629556 --

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by Kubilay Kocak : -- nosy: +koobs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Ned Deily added the comment: This appears to be a duplicate of Issue969718. -- nosy: +ned.deily ___ Python tracker ___ ___

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

Change by STINNER Victor : -- keywords: +patch pull_requests: +12223 stage: -> patch review ___ Python tracker ___ ___

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

New submission from STINNER Victor : When a C extension is built by distutils, distutils.sysconfig.customize_compiler() is used to configure compiler flags. Extract of the code: (cc, cxx, opt, cflags, ccshared, ldshared, shlib_suffix, ar, ar_flags) = \ get_config_vars('CC',