[issue36543] Remove old-deprecated ElementTree features (part 2)

Serhiy Storchaka added the comment: I do not understand what this discussion in a long-closed article is about. If you propose to add warning, I am against it. You are against removing the module. Well, the module will not be removed, the warning is no longer needed. The issue is closed. I

[issue36543] Remove old-deprecated ElementTree features (part 2)

Christian Heimes added the comment: Apparently my defusedxml package is low-quality code... Anyhow PEP 387 has clear rules how to handle incompatible changes. Every core dev has to follow these rules. You cannot simply ignore the rule, because you don't like it. If you want to change the

[issue36543] Remove old-deprecated ElementTree features (part 2)

Serhiy Storchaka added the comment: Deprecation warning may help users of old lower-quality code at the cost of harming users of old higher-quality code. It does not look right to me. -- ___ Python tracker

[issue36543] Remove old-deprecated ElementTree features (part 2)

Christian Heimes added the comment: The process is fine. A deprecation warning will give users time to update code before it hits production. -- ___ Python tracker ___

[issue36543] Remove old-deprecated ElementTree features (part 2)

Petr Viktorin added the comment: Should the process be changed? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36543] Remove old-deprecated ElementTree features (part 2)

Serhiy Storchaka added the comment: This process is not new. The problem is that in this particular case warning will do more harm than removing the module. If we cannot just remove it, we should not introduce warning. It will be kept forever. --

[issue36543] Remove old-deprecated ElementTree features (part 2)

Petr Viktorin added the comment: Let me just point out there's an official process for making incompatible changes now: https://www.python.org/dev/peps/pep-0387/#making-incompatible-changes A warning must be emitted (not just mentioned in docs) for two releases before a feature is removed.

[issue36543] Remove old-deprecated ElementTree features (part 2)

Stefan Behnel added the comment: The xml.etree.cElementTree module is restored. We'll see about what to do with it later. It hurts less to keep it around than to delete it. I think this ticket can be closed. -- resolution: -> fixed stage: patch review -> resolved status: open ->

[issue36543] Remove old-deprecated ElementTree features (part 2)

Stefan Behnel added the comment: New changeset 3b97d1becbe08cf56c58d9c740a4622cbf6285fd by Miss Islington (bot) in branch '3.9': bpo-36543: Revert "bpo-36543: Remove the xml.etree.cElementTree module." (GH-20117) (GH-20780)

[issue36543] Remove old-deprecated ElementTree features (part 2)

Change by miss-islington : -- nosy: +miss-islington nosy_count: 6.0 -> 7.0 pull_requests: +19976 pull_request: https://github.com/python/cpython/pull/20780 ___ Python tracker

[issue36543] Remove old-deprecated ElementTree features (part 2)

Stefan Behnel added the comment: New changeset ec88e1bca81a167e6d5c0ac635e22f84298cb1df by Serhiy Storchaka in branch 'master': bpo-36543: Revert "bpo-36543: Remove the xml.etree.cElementTree module." (GH-20117)

[issue36543] Remove old-deprecated ElementTree features (part 2)

Change by Serhiy Storchaka : -- pull_requests: +19421 pull_request: https://github.com/python/cpython/pull/20117 ___ Python tracker ___

[issue36543] Remove old-deprecated ElementTree features (part 2)

Serhiy Storchaka added the comment: I do not think that it is right to emit a warning at import time. We should not punish people which do things right: fallback to xml.etree.ElementTree and test with -We. -- ___ Python tracker

[issue36543] Remove old-deprecated ElementTree features (part 2)

Change by Christian Heimes : -- pull_requests: +19237 pull_request: https://github.com/python/cpython/pull/19921 ___ Python tracker ___

[issue36543] Remove old-deprecated ElementTree features (part 2)

Change by Serhiy Storchaka : -- pull_requests: +19235 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/19920 ___ Python tracker ___

[issue36543] Remove old-deprecated ElementTree features (part 2)

Stefan Behnel added the comment: >> But as I said, people don't read docs. > After seven, eight years we should do our users a service and point out the > deprecation with a concrete deadline. ¯\_(ツ)_/¯ Honestly, let's just keep it. Maybe we can add an invisible PendingDeprecationWarning

[issue36543] Remove old-deprecated ElementTree features (part 2)

Christian Heimes added the comment: 3.3.0 was released in 2012. That's almost a lifetime ago. I assume that majority of users either forgot, missed the note, or no longer took the deprecation serious. After seven, eight years we should do our users a service and point out the deprecation

[issue36543] Remove old-deprecated ElementTree features (part 2)

Stefan Behnel added the comment: It's not like the deprecation was hidden – the ET docs have this line right at the top: "Changed in version 3.3: This module will use a fast implementation whenever available. The xml.etree.cElementTree module is deprecated."

[issue36543] Remove old-deprecated ElementTree features (part 2)

Christian Heimes added the comment: IMHO we don't have to spend extra work on an import hook. It might be a good idea to raise the problem with https://github.com/PyCQA/, though. Large projects tend to use code checkers and linters. -- ___ Python

[issue36543] Remove old-deprecated ElementTree features (part 2)

Christian Heimes added the comment: Stefan wrote: > Christian, I understand your complaint, but I've actually never seen code in > the wild that didn't provide a fallback for the import, usually something > like what Serhiy spelled out My package defusedxml broke with the change. Python's

[issue36543] Remove old-deprecated ElementTree features (part 2)

Serhiy Storchaka added the comment: Thank you Miro for information. It looks as awesome work! The simplest solution would be to restore xml.etree.cElementTree and keep it forever. It will not harm anyone, it is just outdated import here and there. We could also write an import hook which

[issue36543] Remove old-deprecated ElementTree features (part 2)

Stefan Behnel added the comment: Thanks Miro, that's beautiful. Good to know that I'm not the only one who doesn't read documentation. ;-) So, how do we deal with this? We can't warn about the deprecation without annoying everyone. We can't just remove the empty module without breaking lots

[issue36543] Remove old-deprecated ElementTree features (part 2)

Miro Hrončok added the comment: Some stats: See https://bugzilla.redhat.com/showdependencytree.cgi?id=PYTHON39_resolved=0 and Ctrl+F for cElementTree. -- ___ Python tracker

[issue36543] Remove old-deprecated ElementTree features (part 2)

Serhiy Storchaka added the comment: xml.etree.cElementTree should be treated in the same way as cStringIO and cPickle -- they where separate modules in the past, but now the acceleration is used by default in io.StringIO and pickle. It looks an oversign that it was not removed in 3.0.

[issue36543] Remove old-deprecated ElementTree features (part 2)

Stefan Behnel added the comment: Christian, I understand your complaint, but I've actually never seen code in the wild that didn't provide a fallback for the import, usually something like what Serhiy spelled out and explained above: try: import xml.etree.cElementTree as ET

[issue36543] Remove old-deprecated ElementTree features (part 2)

Christian Heimes added the comment: For the record, I'm quite unhappy that xml.etree.cElementTree was removed without going through a proper active deprecation cycle with plenty of head start. The removal came as a surprise to me -- and I'm a core dev, author of PEP 594 and owner of the

[issue36543] Remove old-deprecated ElementTree features (part 2)

Serhiy Storchaka added the comment: New changeset 6467134307cf01802c9f1c0384d8acbebecbd400 by Miro Hrončok in branch 'master': bpo-36543: What's new: Document how to replace xml.etree.cElementTree (GH-19188) https://github.com/python/cpython/commit/6467134307cf01802c9f1c0384d8acbebecbd400

[issue36543] Remove old-deprecated ElementTree features (part 2)

Change by Miro Hrončok : -- nosy: +hroncok nosy_count: 4.0 -> 5.0 pull_requests: +18547 pull_request: https://github.com/python/cpython/pull/19188 ___ Python tracker ___

[issue36543] Remove old-deprecated ElementTree features (part 2)

Serhiy Storchaka added the comment: New changeset b33e52511a59c6da7132c226b7f7489b092a33eb by Serhiy Storchaka in branch 'master': bpo-36543: Remove the xml.etree.cElementTree module. (GH-19108) https://github.com/python/cpython/commit/b33e52511a59c6da7132c226b7f7489b092a33eb --

[issue36543] Remove old-deprecated ElementTree features (part 2)

Change by Serhiy Storchaka : -- pull_requests: +18469 pull_request: https://github.com/python/cpython/pull/19108 ___ Python tracker ___

[issue36543] Remove old-deprecated ElementTree features (part 2)

Change by Rahul Kumaresan : -- nosy: +rahul-kumi nosy_count: 3.0 -> 4.0 pull_requests: +18289 pull_request: https://github.com/python/cpython/pull/18937 ___ Python tracker ___

[issue36543] Remove old-deprecated ElementTree features (part 2)

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36543] Remove old-deprecated ElementTree features (part 2)

Serhiy Storchaka added the comment: New changeset f02ea6225bc3b71bd5fe66224d199a6e3e23b14d by Serhiy Storchaka in branch 'master': bpo-36543: Remove old-deprecated ElementTree features. (GH-12707) https://github.com/python/cpython/commit/f02ea6225bc3b71bd5fe66224d199a6e3e23b14d --

[issue36543] Remove old-deprecated ElementTree features (part 2)

Serhiy Storchaka added the comment: See also issue29209. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36543] Remove old-deprecated ElementTree features (part 2)

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +12631 stage: -> patch review ___ Python tracker ___ ___

[issue36543] Remove old-deprecated ElementTree features (part 2)

New submission from Serhiy Storchaka : The proposed PR removes old-deprecated ElementTree features. * Methods Element.getchildren(), Element.getiterator() and ElementTree.getiterator() deprecated in 2.7 and 3.2. They were deprecated in the documentation only, and started to emit a warning in