[issue36610] os.sendfile can return EINVAL on Solaris

Change by Giampaolo Rodola' : -- assignee: -> giampaolo.rodola resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36610] os.sendfile can return EINVAL on Solaris

Giampaolo Rodola' added the comment: New changeset 413d955f8ec88a7183f91d7ad8b0ff7def803de3 by Giampaolo Rodola in branch 'master': bpo-36610: shutil.copyfile(): use sendfile() on Linux only (GH-13675) https://github.com/python/cpython/commit/413d955f8ec88a7183f91d7ad8b0ff7def803de3

[issue36610] os.sendfile can return EINVAL on Solaris

Giampaolo Rodola' added the comment: I currently have no Solaris box to test this against and am currently short on time but I'm of the opinion that because of: > Sendfile on Solaris can raise EINVAL if offset is equal or bigger than the size > of the file (Python expects that it will

[issue36610] os.sendfile can return EINVAL on Solaris

Change by Giampaolo Rodola' : -- pull_requests: +13563 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13675 ___ Python tracker ___

[issue36610] os.sendfile can return EINVAL on Solaris

Jakub Kulik added the comment: Here is a traceback from one failed test: test test_lib2to3 failed == ERROR: test_refactor_file_write_unchanged_file (lib2to3.tests.test_refactor.TestRefactoringTool)

[issue36610] os.sendfile can return EINVAL on Solaris

Giampaolo Rodola' added the comment: Can you paste the traceback or are you able to reproduce the bug via a script? sendfile implementation is supposed to giveup if no data was sent on first call, so I suppose this happen later? If for any reason it turns out sendfile() is broken on Solaris

[issue36610] os.sendfile can return EINVAL on Solaris

New submission from Jakub Kulik : Hi, We have several tests failing on Solaris due to the slightly different behavior of os.sendfile function. Sendfile on Solaris can raise EINVAL if offset is equal or bigger than the size of the file (Python expects that it will return 0 bytes sent in that