[issue36974] Implement PEP 590

STINNER Victor added the comment: I created bpo-39361: [C API] Document PyTypeObject.tp_print removal in What's New In Python 3.9. -- ___ Python tracker ___

[issue36974] Implement PEP 590

Petr Viktorin added the comment: issue39245 tracks making the API public in Python 3.9. -- ___ Python tracker ___ ___

[issue36974] Implement PEP 590

miss-islington added the comment: New changeset 9a13a388f202268dd7b771638adbec132449b98b by Miss Islington (bot) (Jeroen Demeyer) in branch 'master': bpo-36974: expand call protocol documentation (GH-13844) https://github.com/python/cpython/commit/9a13a388f202268dd7b771638adbec132449b98b

[issue36974] Implement PEP 590

STINNER Victor added the comment: 'SystemError: bad call flags' error message LGTM, I don't think that it should be changed. > Are there many projects that define functions/methods but never call them? I have no idea. -- ___ Python tracker

[issue36974] Implement PEP 590

Jeroen Demeyer added the comment: > Should we add a note like "if you get a 'SystemError: bad call flags' on > import, check the descriptor flags of your functions" in What's New in Python > 3.8? A better solution would be to change the error message. We could change it to something like

[issue36974] Implement PEP 590

STINNER Victor added the comment: > [3.8] bpo-36974: separate vectorcall functions for each calling convention > (GH-13781) (#14782) > https://github.com/python/cpython/commit/bf8e82f976b37856c7d35cdf88a238cb6f57fe65 FYI this change caused a regression in libcomps with Python 3.8 beta3,

[issue36974] Implement PEP 590

Łukasz Langa added the comment: New changeset bf8e82f976b37856c7d35cdf88a238cb6f57fe65 by Łukasz Langa (Jeroen Demeyer) in branch '3.8': [3.8] bpo-36974: separate vectorcall functions for each calling convention (GH-13781) (#14782)

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- pull_requests: +14578 pull_request: https://github.com/python/cpython/pull/14782 ___ Python tracker ___

[issue36974] Implement PEP 590

Petr Viktorin added the comment: Buildbots are green, closing. Thank you for the implementation! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue36974] Implement PEP 590

Jeroen Demeyer added the comment: Any objections to closing this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36974] Implement PEP 590

Petr Viktorin added the comment: New changeset 0d722f3cd602e5f5492f9c65c8af57ea9d3743b6 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: separate vectorcall functions for each calling convention (GH-13781)

[issue36974] Implement PEP 590

Petr Viktorin added the comment: New changeset 26fe6c35374fa32577b230b856a92a3b094e08ed by Petr Viktorin (Miss Islington (bot)) in branch '3.8': bpo-36974: inherit tp_vectorcall_offset unconditionally (GH-13858) (GH-14342)

[issue36974] Implement PEP 590

Change by miss-islington : -- pull_requests: +14163 pull_request: https://github.com/python/cpython/pull/14342 ___ Python tracker ___

[issue36974] Implement PEP 590

Petr Viktorin added the comment: New changeset a8b27e623d75377aabe50df27e97cab4e81a174a by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: inherit tp_vectorcall_offset unconditionally (GH-13858) https://github.com/python/cpython/commit/a8b27e623d75377aabe50df27e97cab4e81a174a

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- pull_requests: +13733 pull_request: https://github.com/python/cpython/pull/13858 ___ Python tracker ___

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- pull_requests: +13721 pull_request: https://github.com/python/cpython/pull/13844 ___ Python tracker ___

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- pull_requests: +13666 pull_request: https://github.com/python/cpython/pull/13781 ___ Python tracker ___

[issue36974] Implement PEP 590

Petr Viktorin added the comment: New changeset be718c33f06b3496faa61142df24fb071fd5d1f1 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: add some assertions for PEP 590 (GH-13682) https://github.com/python/cpython/commit/be718c33f06b3496faa61142df24fb071fd5d1f1 --

[issue36974] Implement PEP 590

Petr Viktorin added the comment: New changeset 9e3e06e582accec82eb29cf665c3b4c7d84d2eb0 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: document PEP 590 (GH-13450) https://github.com/python/cpython/commit/9e3e06e582accec82eb29cf665c3b4c7d84d2eb0 --

[issue36974] Implement PEP 590

Petr Viktorin added the comment: New changeset e584cbff1ea78e700cf9943d50467e3b58301ccc by Petr Viktorin in branch 'master': bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings (GH-13758) https://github.com/python/cpython/commit/e584cbff1ea78e700cf9943d50467e3b58301ccc

[issue36974] Implement PEP 590

Change by Petr Viktorin : -- pull_requests: +13640 pull_request: https://github.com/python/cpython/pull/13758 ___ Python tracker ___

[issue36974] Implement PEP 590

Petr Viktorin added the comment: New changeset fb9423fd0a85f06affb8c3a8f25dd598a649aa42 by Petr Viktorin in branch 'master': bpo-36974: Make tp_call=PyVectorcall_Call work for inherited types (GH-13699) https://github.com/python/cpython/commit/fb9423fd0a85f06affb8c3a8f25dd598a649aa42

[issue36974] Implement PEP 590

Change by Petr Viktorin : -- pull_requests: +13584 pull_request: https://github.com/python/cpython/pull/13699 ___ Python tracker ___

[issue36974] Implement PEP 590

Petr Viktorin added the comment: I found an issue in PEP 590: When inheriting a heap subclass from a vectorcall class that sets .tp_call=PyVectorcall_Call (as recommended), the subclass does not inherit _Py_TPFLAGS_HAVE_VECTORCALL, and thus PyVectorcall_Call does not work for it. Possible

[issue36974] Implement PEP 590

Benjamin Peterson added the comment: New changeset 530f506ac91338b55cf2be71b1cdf50cb077512f by Benjamin Peterson (Jeroen Demeyer) in branch 'master': bpo-36974: tp_print -> tp_vectorcall_offset and tp_reserved -> tp_as_async (GH-13464)

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- pull_requests: +13569 pull_request: https://github.com/python/cpython/pull/13682 ___ Python tracker ___

[issue36974] Implement PEP 590

Petr Viktorin added the comment: New changeset 37788bc23f6f1ed0362b9b3b248daf296c024849 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: rename _FastCallKeywords -> _Vectorcall (GH-13653) https://github.com/python/cpython/commit/37788bc23f6f1ed0362b9b3b248daf296c024849

[issue36974] Implement PEP 590

Petr Viktorin added the comment: New changeset c145f3bfbe80d498d40848450d4d33c14e2cf782 by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: remove _PyObject_HasFastCall (GH-13460) https://github.com/python/cpython/commit/c145f3bfbe80d498d40848450d4d33c14e2cf782 --

[issue36974] Implement PEP 590

Petr Viktorin added the comment: New changeset 735e8afa9ee942367b5d0807633a2b9f662cbdbf by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: inherit the vectorcall protocol (GH-13498) https://github.com/python/cpython/commit/735e8afa9ee942367b5d0807633a2b9f662cbdbf --

[issue36974] Implement PEP 590

Petr Viktorin added the comment: All stable buildbots are back to green. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue36974] Implement PEP 590

Pablo Galindo Salgado added the comment: Great! Thank you very much for the quick fix for the problem. For AMD64 Ubuntu Shared 3.x, the last build was successful: https://buildbot.python.org/all/#/builders/141/builds/1870/steps/5/logs/stdio --

[issue36974] Implement PEP 590

Petr Viktorin added the comment: No, just https://github.com/python/cpython/pull/13665 is addressing the failures. And it seems that it's successful -- only the slowest of the failed ones (AMD64 Ubuntu Shared 3.x) is still red. bpo-37090 extends the test so it can catch more bugs in the

[issue36974] Implement PEP 590

Pablo Galindo Salgado added the comment: @Petr is https://bugs.python.org/issue37090 and https://github.com/python/cpython/pull/13668 also addressing the buildbot failures? -- ___ Python tracker

[issue36974] Implement PEP 590

Pablo Galindo Salgado added the comment: BUILDBOT FAILURE REPORT === Builder name: AMD64 Ubuntu Shared 3.x Builder url: https://buildbot.python.org/all/#/builders/141/ Build url: https://buildbot.python.org/all/#/builders/141/builds/1866 Failed tests -

[issue36974] Implement PEP 590

Petr Viktorin added the comment: New changeset fecb75c1bb46c818e6579ba422cfa5d0d9d104d1 by Petr Viktorin in branch 'master': bpo-36974: Fix GDB integration (GH-13665) https://github.com/python/cpython/commit/fecb75c1bb46c818e6579ba422cfa5d0d9d104d1 --

[issue36974] Implement PEP 590

Change by Petr Viktorin : -- pull_requests: +13555 pull_request: https://github.com/python/cpython/pull/13665 ___ Python tracker ___

[issue36974] Implement PEP 590

New submission from Petr Viktorin : New changeset aacc77fbd77640a8f03638216fa09372cc21673d by Petr Viktorin (Jeroen Demeyer) in branch 'master': bpo-36974: implement PEP 590 (GH-13185) https://github.com/python/cpython/commit/aacc77fbd77640a8f03638216fa09372cc21673d --

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- pull_requests: +13547 pull_request: https://github.com/python/cpython/pull/13653 ___ Python tracker ___

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- pull_requests: +13414 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- pull_requests: +13397 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- pull_requests: +13370 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- pull_requests: +13367 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- keywords: +patch pull_requests: +13359 stage: -> patch review ___ Python tracker ___ ___

[issue36974] Implement PEP 590

Change by Jeroen Demeyer : -- components: Interpreter Core nosy: Mark.Shannon, jdemeyer, petr.viktorin priority: normal severity: normal status: open title: Implement PEP 590 type: enhancement versions: Python 3.8 ___ Python tracker