[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

Josh Rosenberg added the comment: This may have caused a regression, see #37549. -- nosy: +josh.r ___ Python tracker ___ ___

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

STINNER Victor added the comment: Thanks Zackery Spytz as usual! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

STINNER Victor added the comment: New changeset 693945d45dfe50c843970cab3e3aa1fa3a3eddbe by Victor Stinner (Miss Islington (bot)) in branch '3.8': bpo-37267: Do not check for FILE_TYPE_CHAR in os.dup() on Windows (GH-14051) (GH-14140)

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

STINNER Victor added the comment: New changeset 71589491ad0da27f57789b97354f6094a91e2eb3 by Victor Stinner (Miss Islington (bot)) in branch '3.7': bpo-37267: Do not check for FILE_TYPE_CHAR in os.dup() on Windows (GH-14051) (GH-14141)

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

STINNER Victor added the comment: According to the discussion in PR 14051: if os.dup() fails to make the new file descriptor new inheritable for a character device, the error must not be ignored. Instead, the caller is supposed to use os.dup(fd, inheritable=False). Before *this bugfix*,

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

Change by miss-islington : -- pull_requests: +13982 pull_request: https://github.com/python/cpython/pull/14141 ___ Python tracker ___

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

Change by miss-islington : -- pull_requests: +13981 pull_request: https://github.com/python/cpython/pull/14140 ___ Python tracker ___

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

STINNER Victor added the comment: New changeset 28fca0c422b425a6be43be31add0a5328c16b0b8 by Victor Stinner (Zackery Spytz) in branch 'master': bpo-37267: Do not check for FILE_TYPE_CHAR in os.dup() on Windows (GH-14051)

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

STINNER Victor added the comment: If you care of inherited handles on Windows, please have a look at: * https://github.com/python/cpython/pull/7827 from https://bugs.python.org/issue18174 * https://github.com/python/cpython/pull/7966 from https://bugs.python.org/issue33966 ref:

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

Change by Zackery Spytz : -- keywords: +patch pull_requests: +13913 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14051 ___ Python tracker ___

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

New submission from Zackery Spytz : In PR 13739, Eryk Sun mentioned that the Windows implementation of os.dup() returns an inheritable fd when handling a character file. A comment in _Py_dup() makes it seem as though this is due to a belief that handles for character files cannot be made