[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Safihre added the comment: Implementing for write is not needed as OpenSSL's SSL_write_ex that is used by write() already writes the whole buffer at once. Only reading OpenSSL does in the 16k segments. The new option was introduced to prevent the compatibility problems for code that would

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Christian Heimes added the comment: We have very few people that are familar with ssl module and especially with its I/O layer. I'm busy with other topics. Others are directly affected by war in Ukraine. I'm not a particular fan of the new "eager_recv" property introduced by your PR. Also

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Change by Andrew Svetlov : -- nosy: -asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Safihre added the comment: Pinging in hope for a review on https://github.com/python/cpython/pull/31492 -- ___ Python tracker ___

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Safihre added the comment: Could the new PR be reviewed? Thank you! https://github.com/python/cpython/pull/31492 Documentation still needs updating, but would like feedback. PS: Why not enable the setting the GitHub Actions workflow only need to be approved for new GitHub accounts instead of

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Change by Safihre : -- pull_requests: +29622 pull_request: https://github.com/python/cpython/pull/31492 ___ Python tracker ___ ___

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Change by jakirkham : -- nosy: +jakirkham ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Change by Christian Heimes : -- assignee: christian.heimes -> components: -Installation, Interpreter Core, Library (Lib), Windows, XML, ctypes, email versions: +Python 3.11 -Python 3.10 ___ Python tracker

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Change by Antoine Pitrou : -- nosy: +Matthew Rocklin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Change by Savage Hood : -- assignee: -> christian.heimes components: +Installation, Interpreter Core, Library (Lib), Windows, XML, ctypes, email nosy: +barry, paul.moore, r.david.murray, steve.dower, tim.golden, zach.ware ___ Python tracker

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Safihre added the comment: Is anyone available to give feedback on the remaining questions/problems in the PR? I don't want to be pushy and if it's only changed in 3.11, I understand, but just hoping for some progress :) Also willing to dive into it myself, but not a network/python-core

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Christian Heimes added the comment: You could try to convince Pablo. He is the release manager for 3.10. He can grant exceptions. I also included Benjamin, Nathaniel, and Victor in the nosy list. They have a deeper understanding of the network I/O layer than me. I mostly take care of the

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Safihre added the comment: Understandable, as the feature freeze was yesterday :) Just like to note that we have a 100.000 or so users (which I know is very little compared to overal number of Python users) of our application that this could really help. We have used a lot of CPU cycles

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Christian Heimes added the comment: The PR is still experimental and only applies to one direction. I doubt that it will be ready, reviewed, and approved for feature freeze of 3.10. -- ___ Python tracker

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Safihre added the comment: It would be very beneficial if this gets added. In our application (usenet client) I have wondered for years why we had to limit ourselves to 16k blocks and have such lower speeds compared to non SSL connections. -- nosy: +Safihre

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Change by Josh Snyder : -- keywords: +patch pull_requests: +24203 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25478 ___ Python tracker ___

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Christian Heimes added the comment: Josh, could you please rebase your branch and create a pull request? The PR process will verify that you have submitted a CLA. -- ___ Python tracker

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Dima Tisnek added the comment: Amazing! Would you consider making a pull request out of your branch? re: `PyErr_HasSignals` is a notable addition to the cpython API, it may need discussion, and (imo) documentation. -- nosy: +Dima.Tisnek ___

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Change by Christian Heimes : -- assignee: christian.heimes -> versions: +Python 3.10 -Python 3.9 ___ Python tracker ___ ___

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

Change by Antoine Pitrou : -- nosy: +asvetlov, yselivanov versions: +Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

New submission from Josh Snyder : Background: SSLSocket.read drops the GIL and performs exactly one successful call to OpenSSL's `SSL_read`, whose documentation states "At most the contents of one record will be returned". TLS records are at most 16KB, so high throughput (especially