[issue37499] test_gdb.test_pycfunction should use dedicated test functions

Paul Ganssle added the comment: This is done, thanks Petr and Jeroen! I don't see a need to backport this unless we also want to backport GH-14311 or something else that depends on it. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue37499] test_gdb.test_pycfunction should use dedicated test functions

miss-islington added the comment: New changeset f958377b67c36a98d4df67b94c01eb29e3104f61 by Miss Islington (bot) (Petr Viktorin) in branch 'master': bpo-37499: Test various C calling conventions (GH-15776) https://github.com/python/cpython/commit/f958377b67c36a98d4df67b94c01eb29e3104f61

[issue37499] test_gdb.test_pycfunction should use dedicated test functions

Change by Petr Viktorin : -- pull_requests: +15429 pull_request: https://github.com/python/cpython/pull/15776 ___ Python tracker ___

[issue37499] test_gdb.test_pycfunction should use dedicated test functions

Change by Jeroen Demeyer : -- keywords: +patch pull_requests: +14589 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14795 ___ Python tracker

[issue37499] test_gdb.test_pycfunction should use dedicated test functions

STINNER Victor added the comment: By the way, PyObject_CallFunction("O") has a surprising behavior: if you pass a tuple, the tuple is unpacked, whereas any other type is passed directly. See bpo-28977. I would prefer to fix the API since it caused severe bugs in the past, like asyncio

[issue37499] test_gdb.test_pycfunction should use dedicated test functions

STINNER Victor added the comment: > Per Victor's suggestion in GH-14330, I think we should expose a few test > functions in the `testcapi` module as exemplars of their respective calling > conventions and use those, rather than arbitrary builtins. I suggest to write functions which return

[issue37499] test_gdb.test_pycfunction should use dedicated test functions

New submission from Paul Ganssle : Currently, `test_pycfunction` picks a few built-in functions with various calling conventions to exercise all the relevant code paths: for py_name, py_args, c_name, expected_frame_number in ( ('gmtime', '', 'time_gmtime', 1), #