[issue37562] PEP 590 implementation introduced a performance regression

2019-07-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: >which commits are you comparing exactly? From your explanation, I guess >aacc77fbd and its parent, but that's not completely fair since PEP 590 >consists of many commits (see #36974). A better comparison would be master >against 3.8a4. I am

[issue37562] PEP 590 implementation introduced a performance regression

2019-07-11 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: Could you please specify: - which commits are you comparing exactly? From your explanation, I guess aacc77fbd and its parent, but that's not completely fair since PEP 590 consists of many commits (see #36974). A better comparison would be master against

[issue37562] PEP 590 implementation introduced a performance regression

2019-07-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Updated stack for the tip of 3.8: * frame #0: 0x00010015854e python.exe`unicode_length(self=0x0001014a4040) at unicodeobject.c:12235:9 frame #1: 0x0001a913 python.exe`PyObject_Size(o=0x0001014a4040) at abstract.c:57:26

[issue37562] PEP 590 implementation introduced a performance regression

2019-07-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This is the stack difference for my previous experiment: * frame #0: 0x0001001578ee python.exe`unicode_length(self=0x00010140d220) at unicodeobject.c:12231:9 frame #1: 0x0001b453 python.exe`PyObject_Size(o=0x00010140d220)

[issue37562] PEP 590 implementation introduced a performance regression

2019-07-11 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I have bisected again and I always get commit aacc77fbd77640a8f03638216fa09372cc21673d but it would be great if someone can confirm these results independently. -- ___ Python tracker

[issue37562] PEP 590 implementation introduced a performance regression

2019-07-11 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : Many functions are significantly slower after commit aacc77fbd77640a8f03638216fa09372cc21673d was applied: aacc77fbd77640a8f03638216fa09372cc21673d is the first bad commit commit aacc77fbd77640a8f03638216fa09372cc21673d Author: Jeroen Demeyer Date: