[issue37585] Comparing PyDictValues does not give expected results

miss-islington added the comment: New changeset 690a16d455603500a0c6df0bd87e49c9b37a6950 by Miss Islington (bot) in branch '3.8': bpo-37585: Add clarification regarding comparing dict.values() (GH-14954) https://github.com/python/cpython/commit/690a16d455603500a0c6df0bd87e49c9b37a6950

[issue37585] Comparing PyDictValues does not give expected results

miss-islington added the comment: New changeset 3cd147bf599f116593dc06ed7dfe948b759aabd3 by Miss Islington (bot) in branch '3.7': bpo-37585: Add clarification regarding comparing dict.values() (GH-14954) https://github.com/python/cpython/commit/3cd147bf599f116593dc06ed7dfe948b759aabd3

[issue37585] Comparing PyDictValues does not give expected results

Change by Brett Cannon : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue37585] Comparing PyDictValues does not give expected results

Change by miss-islington : -- pull_requests: +15549 pull_request: https://github.com/python/cpython/pull/15908 ___ Python tracker ___

[issue37585] Comparing PyDictValues does not give expected results

Change by miss-islington : -- pull_requests: +15550 pull_request: https://github.com/python/cpython/pull/15909 ___ Python tracker ___

[issue37585] Comparing PyDictValues does not give expected results

Brett Cannon added the comment: New changeset 6472ece5a0fe82809d3aa0ffb281796fcd252d76 by Brett Cannon (Kyle Stanley) in branch 'master': bpo-37585: Add clarification regarding comparing dict.values() (GH-14954)

[issue37585] Comparing PyDictValues does not give expected results

Change by Kyle Stanley : -- stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37585] Comparing PyDictValues does not give expected results

Kyle Stanley added the comment: Reopening the issue for adding the documentation clarification, that comparing the values view of two dictionaries will always return false (as was suggested in the ML discussion

[issue37585] Comparing PyDictValues does not give expected results

Kyle Stanley added the comment: Added Brett to the nosy list since he was the one who suggested a documentation change. -- nosy: +brett.cannon ___ Python tracker ___

[issue37585] Comparing PyDictValues does not give expected results

Kyle Stanley added the comment: Based on the current status of the discussion in python-dev, the most agreed upon solution so far seems to be updating the documentation to mention this behavior, rather than modifying the existing behavior. I opened a PR which updates the documentation for

[issue37585] Comparing PyDictValues does not give expected results

Change by Kyle Stanley : -- pull_requests: +14723 pull_request: https://github.com/python/cpython/pull/14954 ___ Python tracker ___

[issue37585] Comparing PyDictValues does not give expected results

Change by Serhiy Storchaka : -- resolution: -> duplicate stage: patch review -> resolved status: open -> closed superseder: -> dict view values objects are missing tp_richcmp and tp_as_number ___ Python tracker

[issue37585] Comparing PyDictValues does not give expected results

Karthikeyan Singaravelan added the comment: See also issue12445 which was a similar proposal rejected in the past. -- nosy: +inada.naoki, xtreak ___ Python tracker ___

[issue37585] Comparing PyDictValues does not give expected results

Change by Roundup Robot : -- keywords: +patch pull_requests: +14531 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14737 ___ Python tracker ___

[issue37585] Comparing PyDictValues does not give expected results

New submission from Kristian Klette : As a user, I expect to be able to compare the different parts a `dict` in the same manner. Currently, `PyDictValues` does not implement the `dictview_richcompare`, causing the `__eq__` to always return false, even if the values are identical. ```