[issue37609] support "UNC" device paths in ntpath.splitdrive

Steve Dower added the comment: If you can build this on top of nt._path_splitroot then it could save a decent amount of work, though at the same time I think it's worthwhile having a pure Python implementation which is cross-platform. Haven't looked at the PR yet (or Eryk's implementation

[issue37609] support "UNC" device paths in ntpath.splitdrive

Change by Eryk Sun : -- Removed message: https://bugs.python.org/msg390391 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37609] support "UNC" device paths in ntpath.splitdrive

Change by Barney Gale : -- pull_requests: +29822 pull_request: https://github.com/python/cpython/pull/31702 ___ Python tracker ___

[issue37609] support "UNC" device paths in ntpath.splitdrive

Barney Gale added the comment: I'd like to pick this up, as it would allow us to remove a duplicate implementation in pathlib with its own shortcomings. If using native functionality if difficult to get right, could I put @eryksun's splitdrive.py implementation up for review? --

[issue37609] support "UNC" device paths in ntpath.splitdrive

Change by Steve Dower : -- assignee: steve.dower -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37609] support "UNC" device paths in ntpath.splitdrive

Change by Steve Dower : -- pull_requests: +23997 pull_request: https://github.com/python/cpython/pull/25261 ___ Python tracker ___

[issue37609] support "UNC" device paths in ntpath.splitdrive

Eryk Sun added the comment: > I've got a fairly simple implementation for this using the (new) > nt._path_splitroot native method It's for the best to let the system path API handle this, especially if doing so gets this issue resolved, as well as others like it and those that depend on

[issue37609] support "UNC" device paths in ntpath.splitdrive

Steve Dower added the comment: Once issue43105 is merged, I've got a fairly simple implementation for this using the (new) nt._path_splitroot native method, as well as improved tests that cover both the native and emulated calculations. -- assignee: -> steve.dower versions: +Python

[issue37609] support "UNC" device paths in ntpath.splitdrive

Change by Eryk Sun : Removed file: https://bugs.python.org/file48607/splitdrive.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37609] support "UNC" device paths in ntpath.splitdrive

Eryk Sun added the comment: I'm attaching a rewrite of splitdrive() from msg352355. This version uses an internal _next() function to get the indices of the next path component, ignoring repeated separators. It also flattens the nested structure of the previous implementation by adding

[issue37609] support "UNC" device paths in ntpath.splitdrive

Eryk Sun added the comment: Please consult the attached file "splitdrive.py". I redesigned splitdrive() to support "UNC" and "GLOBAL" junctions in device paths. I relaxed the design to allow repeated separators everywhere except for the UNC root. IIRC, Windows has supported this since XP.

[issue37609] support "UNC" device paths in ntpath.splitdrive

Steve Dower added the comment: For clarity, given Eryk's examples above, both "\\?\UNC\" and "//?/UNC/" are okay (as are any combination of forward and backslashes in the prefix, as normalization will be applied for any except the "\\?\" version). "UNC" is also case-insensitive. --

[issue37609] support "UNC" device paths in ntpath.splitdrive

Ngalim Siregar added the comment: I was unsure about implementation in the patch, do you have UNC format specification? -- nosy: +nsiregar ___ Python tracker ___

[issue37609] support "UNC" device paths in ntpath.splitdrive

Change by Ngalim Siregar : -- keywords: +patch pull_requests: +14632 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14841 ___ Python tracker

[issue37609] support "UNC" device paths in ntpath.splitdrive

Serhiy Storchaka added the comment: Do you want to create a PR Eryk? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue37609] support "UNC" device paths in ntpath.splitdrive

New submission from Eryk Sun : Windows Python includes UNC shares such as "//server/spam" in its definition of a drive. This is natural because Windows supports setting a UNC path as the working directory and handles the share component as the working drive when resolving rooted paths such