[issue37628] IDLE: Fix Font sample (config dialog) geometry

Tal Einat added the comment: Terry, thanks for reviewing, helping get this fully ready, and merging. Kyle, thanks for the kind feedback, it's truly heart-warming! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue37628] IDLE: Fix Font sample (config dialog) geometry

Kyle Stanley added the comment: Correction: By "scroll the list of fonts" I meant that I went through all of them by holding the down arrow from the top of the list (Adobe Courier - Z003), scrolling through the list wouldn't accomplish anything. I did that starting with a font size 40 and a

[issue37628] IDLE: Fix Font sample (config dialog) geometry

Kyle Stanley added the comment: After PR-14958 was merged, I tested the latest development version of CPython on Arch Linux 5.2.3 and I can confirm that the "Settings" window no longer scales past the edge of the screen. Instead, the window size remains fixed and the scroll area dynamically

[issue37628] IDLE: Fix Font sample (config dialog) geometry

miss-islington added the comment: New changeset 171019354aa2c717af2e7b2c90aec7b9724f7282 by Miss Islington (bot) in branch '3.8': bpo-37628: Fix IDLE config sample sizes (GH-14958) https://github.com/python/cpython/commit/171019354aa2c717af2e7b2c90aec7b9724f7282 --

[issue37628] IDLE: Fix Font sample (config dialog) geometry

miss-islington added the comment: New changeset 0242eb3fa7818eb078c0915a4b844c5a2070b810 by Miss Islington (bot) in branch '3.7': bpo-37628: Fix IDLE config sample sizes (GH-14958) https://github.com/python/cpython/commit/0242eb3fa7818eb078c0915a4b844c5a2070b810 -- nosy:

[issue37628] IDLE: Fix Font sample (config dialog) geometry

Change by miss-islington : -- pull_requests: +14748 pull_request: https://github.com/python/cpython/pull/14981 ___ Python tracker ___

[issue37628] IDLE: Fix Font sample (config dialog) geometry

Change by miss-islington : -- pull_requests: +14747 pull_request: https://github.com/python/cpython/pull/14980 ___ Python tracker ___

[issue37628] IDLE: Fix Font sample (config dialog) geometry

Terry J. Reedy added the comment: New changeset 3221a63c69268a9362802371a616f49d522a5c4f by Terry Jan Reedy (Tal Einat) in branch 'master': bpo-37628: Fix IDLE config sample sizes (#14958) https://github.com/python/cpython/commit/3221a63c69268a9362802371a616f49d522a5c4f --

[issue37628] IDLE: Fix Font sample (config dialog) geometry

Tal Einat added the comment: See proposed fix in PR GH-14958. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37628] IDLE: Fix Font sample (config dialog) geometry

Change by Tal Einat : -- keywords: +patch pull_requests: +14726 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14958 ___ Python tracker

[issue37628] IDLE: Fix Font sample (config dialog) geometry

Terry J. Reedy added the comment: And maybe a horizontal scroll. In any case, line wrap should be off. Feel free to whip up a minimal change PR that we can merge before Monday. -- ___ Python tracker

[issue37628] IDLE: Fix Font sample (config dialog) geometry

Tal Einat added the comment: Since it's a text widget, it would be simple and rather intuitive to make it scrollable. We could then make its size set according to the size of the config dialog window, rather than the other way around. -- ___

[issue37628] IDLE: Fix Font sample (config dialog) geometry

Terry J. Reedy added the comment: I consider it a bug for *IDLE* to place and size windows so that the bottom of the window is hidden. (If users, perhaps temporarily, move a window down so that the bottom is hidden, that is their business.) This is especially bad for the Settings dialog