[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Steve Dower added the comment: Fixed via issue39439 -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Steve Dower added the comment: New changeset 6990d1b6131873c7f0913908162e4c723d00ea19 by Steve Dower (Adam Meily) in branch '3.7': bpo-38092: Reduce overhead when using multiprocessing in a Windows virtual environment (GH-16098)

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Change by Adam Meily : -- pull_requests: +17543 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18157 ___ Python tracker ___

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Steve Dower added the comment: You're right, the logic to actually launch _base_executable is in there twice now, and the second one (that never gets used) is more important. -- ___ Python tracker

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Eryk Sun added the comment: This should revert to setting `_python_exe = sys.executable` in Lib/multiprocessing/spawn.py. Then the code in Lib/multiprocessing/popen_spawn_win32.py will set __PYVENV_LAUNCHER__ in the spawned process to the virtual environment's sys.executable. Otherwise the

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

miss-islington added the comment: New changeset 436b429ade87b10879b3f944e99a515478e86e5e by Miss Islington (bot) in branch '3.8': bpo-38092: Reduce overhead when using multiprocessing in a Windows virtual environment (GH-16098)

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Steve Dower added the comment: Thanks for the report and partial patch! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

miss-islington added the comment: New changeset f2b7556ef851ac85e7cbf189d1b29fdeb9539b88 by Miss Islington (bot) (Steve Dower) in branch 'master': bpo-38092: Reduce overhead when using multiprocessing in a Windows virtual environment (GH-16098)

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Change by miss-islington : -- pull_requests: +15731 pull_request: https://github.com/python/cpython/pull/16116 ___ Python tracker ___

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Steve Dower added the comment: I posted a second PR with the rest of the change, as it'd be good to get this in before the next 3.8 release. -- versions: -Python 3.7 ___ Python tracker

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Change by Steve Dower : -- pull_requests: +15718 pull_request: https://github.com/python/cpython/pull/16098 ___ Python tracker ___

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Steve Dower added the comment: The difference is that launching sys._base_executable *without* __PYVENV_LAUNCHER__ set (because env is not being passed) should lose you access to anything installed into the venv. You may also need to import something from the venv in order to see the issue.

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Change by Pierre Glaser : -- keywords: +patch pull_requests: +15524 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15883 ___ Python tracker ___

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Pierre Glaser added the comment: > Dropping this into Lib/multiprocessing/spawn.py should cause a repro: if WINSERVICE: _python_exe = os.path.join(sys.exec_prefix, 'python.exe') else: _python_exe = getattr(sys, '_base_executable', sys.executable) In this case,

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

Steve Dower added the comment: Yeah, very strange that. I can only assume that it's launching the venv redirector directly, rather than the real sys.executable, and we aren't ever calling set_executable() with the real one anymore. Dropping this into Lib/multiprocessing/spawn.py should

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

New submission from Pierre Glaser : If I am not mistaken, when creating a new process on Python3.7 and later on Windows, if using a virtualenv, Python now uses a launcher. The launcher is being notified that it must create a virtual-environment Python (and not a system Python) program using