[issue38113] Remove statics from ast.c

Łukasz Langa added the comment: New changeset 55e0836849c14fb474e1ba7f37851e07660eea3c by Pablo Galindo in branch '3.9': [3.9] bpo-41631: _ast module uses again a global state (GH-21961) (GH-22258) https://github.com/python/cpython/commit/55e0836849c14fb474e1ba7f37851e07660eea3c --

[issue38113] Remove statics from ast.c

Change by Pablo Galindo Salgado : -- nosy: +pablogsal nosy_count: 5.0 -> 6.0 pull_requests: +21314 pull_request: https://github.com/python/cpython/pull/22258 ___ Python tracker

[issue38113] Remove statics from ast.c

Łukasz Langa added the comment: New changeset e5fbe0cbd4be99ced5f000ad382208ad2a561c90 by Victor Stinner in branch 'master': bpo-41631: _ast module uses again a global state (#21961) https://github.com/python/cpython/commit/e5fbe0cbd4be99ced5f000ad382208ad2a561c90 -- nosy:

[issue38113] Remove statics from ast.c

STINNER Victor added the comment: > This change introduced a subtle regression: bpo-41194. I modified the _ast > module to use again a global state: (...) Sadly, my fix doesn't work in all cases, there is yet another bug: bpo-41631 "_ast module: get_global_ast_state() doesn't work with

[issue38113] Remove statics from ast.c

STINNER Victor added the comment: > New changeset ac46eb4ad6662cf6d771b20d8963658b2186c48c by Eric Snow (Dino > Viehland) in branch 'master': > bpo-38113: Update the Python-ast.c generator to PEP384 (gh-15957) This change introduced a subtle regression: bpo-41194. I modified the _ast module

[issue38113] Remove statics from ast.c

STINNER Victor added the comment: This change introduced tons of reference leaks, more than 21 test files leak references: see bpo-38152. Please fix these leaks, or I will have to revert the change: https://pythondev.readthedocs.io/ci.html#revert-on-fail -- nosy: +vstinner

[issue38113] Remove statics from ast.c

Change by Eric Snow : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38113] Remove statics from ast.c

Eric Snow added the comment: New changeset ac46eb4ad6662cf6d771b20d8963658b2186c48c by Eric Snow (Dino Viehland) in branch 'master': bpo-38113: Update the Python-ast.c generator to PEP384 (gh-15957) https://github.com/python/cpython/commit/ac46eb4ad6662cf6d771b20d8963658b2186c48c

[issue38113] Remove statics from ast.c

miss-islington added the comment: New changeset 5b172c27f760dc5437e37dd8f1540eb76440e9a7 by Miss Islington (bot) (Dino Viehland) in branch 'master': bpo-38113: Update Python/ast.c to PEP-384 (GH-15975) https://github.com/python/cpython/commit/5b172c27f760dc5437e37dd8f1540eb76440e9a7

[issue38113] Remove statics from ast.c

Change by Dino Viehland : -- pull_requests: +15608 pull_request: https://github.com/python/cpython/pull/15975 ___ Python tracker ___

[issue38113] Remove statics from ast.c

Dino Viehland added the comment: Remove statics to make more compatible with subinterpreters. -- components: +Interpreter Core -Extension Modules title: Make ast module PEP-384 compatible -> Remove statics from ast.c ___ Python tracker