[issue38215] Do not import modules in star-import when __all__ is not defined.

Change by Serhiy Storchaka : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38215] Do not import modules in star-import when __all__ is not defined.

Ethan Furman added the comment: It's the casual users' code that will break. -- ___ Python tracker ___ ___ Python-bugs-list

[issue38215] Do not import modules in star-import when __all__ is not defined.

Serhiy Storchaka added the comment: I believe that significant part or even most of code is writing without using linters and type checkers. Python is too convenient for non-professional programmers. You do not need to declare all variables with their types to use Python and do not need to

[issue38215] Do not import modules in star-import when __all__ is not defined.

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38215] Do not import modules in star-import when __all__ is not defined.

Change by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38215] Do not import modules in star-import when __all__ is not defined.

Ethan Furman added the comment: I don't think this is worth the code breakage. The advice already given is not to use `import *` unless: - the module was designed for that usage; or - you know what you are doing. -- nosy: +ethan.furman ___ Python

[issue38215] Do not import modules in star-import when __all__ is not defined.

Guido van Rossum added the comment: I feel that this is a relatively minor issue, and not worth breaking "working" code over. Some more pedantic tool like a linter or type checker would be a better place to start diagnosing this. -- ___ Python

[issue38215] Do not import modules in star-import when __all__ is not defined.

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +15856 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16263 ___ Python tracker

[issue38215] Do not import modules in star-import when __all__ is not defined.

New submission from Serhiy Storchaka : If __all__ is not defined in a module "from module import *" will import all keys from module.__dict__ which does not start with underscore. It can add undesired names to the current namespace. The common case is related to importing modules. 1.