[issue38256] binascii.crc32 is not 64-bit clean when USE_ZLIB_CRC32

Gregory P. Smith added the comment: 3.8 and older are in security fix only mode. 3.9+ have been fixed. realistically this was a rare issue with multiple workarounds. The 3.9 and 3.10 fixes were strictly bugfix only. The 3.11 fix included some performance improvements. --

[issue38256] binascii.crc32 is not 64-bit clean when USE_ZLIB_CRC32

Gregory P. Smith added the comment: New changeset 58a7e130375776b192a99b013bc563205a639edc by Gregory P. Smith in branch '3.9': bpo-38256: Fix binascii.crc32 large input. (GH-32000) (GH-32013) (GH-32015) https://github.com/python/cpython/commit/58a7e130375776b192a99b013bc563205a639edc

[issue38256] binascii.crc32 is not 64-bit clean when USE_ZLIB_CRC32

Change by Gregory P. Smith : -- pull_requests: +30103 pull_request: https://github.com/python/cpython/pull/32015 ___ Python tracker ___

[issue38256] binascii.crc32 is not 64-bit clean when USE_ZLIB_CRC32

Gregory P. Smith added the comment: New changeset 4c989e19c84ec224655bbbde9422e16d4a838a80 by Gregory P. Smith in branch '3.10': [3.10] bpo-38256: Fix binascii.crc32 large input. (GH-32000) (GH-32013) https://github.com/python/cpython/commit/4c989e19c84ec224655bbbde9422e16d4a838a80

[issue38256] binascii.crc32 is not 64-bit clean when USE_ZLIB_CRC32

Change by Gregory P. Smith : -- pull_requests: +30101 pull_request: https://github.com/python/cpython/pull/32013 ___ Python tracker ___

[issue38256] binascii.crc32 is not 64-bit clean when USE_ZLIB_CRC32

Gregory P. Smith added the comment: New changeset 9d1c4d69dbc800ac344565119337fcf490cdc800 by Gregory P. Smith in branch 'main': bpo-38256: Fix binascii.crc32() when inputs are 4+GiB (GH-32000) https://github.com/python/cpython/commit/9d1c4d69dbc800ac344565119337fcf490cdc800 --

[issue38256] binascii.crc32 is not 64-bit clean when USE_ZLIB_CRC32

Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38256] binascii.crc32 is not 64-bit clean when USE_ZLIB_CRC32

Change by Gregory P. Smith : -- keywords: +patch pull_requests: +30089 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/32000 ___ Python tracker

[issue38256] binascii.crc32 is not 64-bit clean when USE_ZLIB_CRC32

Gregory P. Smith added the comment: it depends on the build. USE_ZLIB_CRC32 causes it due to zlib's 32-bitness as noted my marko. $ ./python Python 3.11.0a6+ (heads/main-dirty:b3f2d4c8ba, Mar 19 2022, 15:32:04) [GCC 9.4.0] on linux Type "help", "copyright", "credits" or "license" for more

[issue38256] binascii.crc32 is not 64-bit clean

Gregory P. Smith added the comment: ``` $ python3.8 Python 3.8.10 (default, Nov 26 2021, 20:14:08) [GCC 9.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import binascii, zlib >>> bigdata=memoryview(bytearray((1<<32) + 100)) >>> >>>

[issue38256] binascii.crc32 is not 64-bit clean

Change by Serhiy Storchaka : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38256] binascii.crc32 is not 64-bit clean

marko kreen added the comment: Found zlibmodule fix: https://bugs.python.org/issue10276 -- versions: +Python 3.8, Python 3.9 ___ Python tracker ___

[issue38256] binascii.crc32 is not 64-bit clean

marko kreen added the comment: Looking at the code, the bug is dependant on USE_ZLIB_CRC32 define and it's unfixed in master. Cause is zlib crc32 that takes length as integer, zlibmodule has workaround, binascii has not. -- ___ Python tracker

[issue38256] binascii.crc32 is not 64-bit clean

Александр Семенов added the comment: I've got Python 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 22:22:05) [MSC v.1916 64 bit (AMD64)] 2838121701 2838121701 2838121701 2838121701 -- nosy: +iamsav ___ Python tracker

[issue38256] binascii.crc32 is not 64-bit clean

New submission from marko kreen : Following code: import binascii, zlib bigdata=memoryview(bytearray((1<<32) + 100)) print(binascii.crc32(bigdata)) crc = binascii.crc32(bigdata[:1000]) crc = binascii.crc32(bigdata[1000:], crc) print(crc) print(zlib.crc32(bigdata))