[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: It was decided to abandon the idea of stable ABI for PyConfig: see bpo-38326. I now close this issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue38304] PEP 587 implementation is not ABI forward compatible

miss-islington added the comment: New changeset d49f096cc41f57155efe71cd089c29b38c218488 by Miss Islington (bot) in branch '3.8': bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore (GH-16509) https://github.com/python/cpython/commit/d49f096cc41f57155efe71cd089c29b38c218488

[issue38304] PEP 587 implementation is not ABI forward compatible

Change by miss-islington : -- pull_requests: +16100 pull_request: https://github.com/python/cpython/pull/16510 ___ Python tracker ___

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: New changeset 8462a4936b3a551dc546a6adea04a70b0a07ca67 by Victor Stinner in branch 'master': bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore (GH-16509) https://github.com/python/cpython/commit/8462a4936b3a551dc546a6adea04a70b0a07ca67 --

[issue38304] PEP 587 implementation is not ABI forward compatible

Change by STINNER Victor : -- pull_requests: +16099 pull_request: https://github.com/python/cpython/pull/16509 ___ Python tracker ___

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: New changeset 3c30a76f3d3c0dcc1fb4de097fa4a3a4c92c0b0b by Victor Stinner in branch 'master': bpo-38304: Remove PyConfig.struct_size (GH-16500) (GH-16508) https://github.com/python/cpython/commit/3c30a76f3d3c0dcc1fb4de097fa4a3a4c92c0b0b --

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: > Will you forward port your change to master, Victor? Sure, it was my plan: PR 16508. I chose to fix 3.8 first to unblock the 3.8.0rc1 release. -- ___ Python tracker

[issue38304] PEP 587 implementation is not ABI forward compatible

Change by STINNER Victor : -- pull_requests: +16098 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/16508 ___ Python tracker ___

[issue38304] PEP 587 implementation is not ABI forward compatible

Łukasz Langa added the comment: Will you forward port your change to master, Victor? -- ___ Python tracker ___ ___ Python-bugs-list

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: I reopen the issue since there seems to be disagreement about the whole feature (provide a stable ABI for embedded Python): see bpo-38326. -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue38304] PEP 587 implementation is not ABI forward compatible

Change by STINNER Victor : -- pull_requests: +16089 pull_request: https://github.com/python/cpython/pull/16500 ___ Python tracker ___

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: New changeset 81f6b031c46721478372d77fe2e55aa1f8300ae1 by Victor Stinner in branch '3.8': bpo-38304: Fix PyConfig usage in python_uwp.cpp (GH-16488) https://github.com/python/cpython/commit/81f6b031c46721478372d77fe2e55aa1f8300ae1 --

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: New changeset 89f8177dcfdbcf17c85bb6998c946c9f42bf6e27 by Victor Stinner in branch 'master': bpo-38304: Fix PyConfig usage in python_uwp.cpp (GH-16487) https://github.com/python/cpython/commit/89f8177dcfdbcf17c85bb6998c946c9f42bf6e27 --

[issue38304] PEP 587 implementation is not ABI forward compatible

Change by STINNER Victor : -- pull_requests: +16074 pull_request: https://github.com/python/cpython/pull/16488 ___ Python tracker ___

[issue38304] PEP 587 implementation is not ABI forward compatible

Change by STINNER Victor : -- pull_requests: +16073 pull_request: https://github.com/python/cpython/pull/16487 ___ Python tracker ___

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: > Both it and struct_size should be removed, as we don't support updating an > embedded Python runtime to a new X.Y.0 release without rebuilding the > embedding application. See my reply on python-dev:

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: > The hidden _config_version field wasn't in the accepted PEP. It was in the accepted PEP and I replaced it with struct_size: https://github.com/python/peps/commit/afa38c0bef7738b8fcc3173daee8488e0420833d I suggest to discuss the issue on the thread that I

[issue38304] PEP 587 implementation is not ABI forward compatible

Ned Deily added the comment: Nick, do you consider this a 3.8.0 release blocker? If so, you should reopen it and mark it as such, since the 3.8.0rc1 cutoff is imminent. -- nosy: +ned.deily ___ Python tracker

[issue38304] PEP 587 implementation is not ABI forward compatible

Nick Coghlan added the comment: The hidden _config_version field wasn't in the accepted PEP. Both it and struct_size should be removed, as we don't support updating an embedded Python runtime to a new X.Y.0 release without rebuilding the embedding application. -- nosy: +ncoghlan

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: Ok, the API should now be ABI future proof thanks to this change. I experimented a change locally: it's possible to support two sizes of the PyConfig structure (need to modify a few functions in initconfig.c). I sent an email to python-dev:

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: New changeset 6e128382b3e7f83d91d5e73d83a051ff5fb6469c by Victor Stinner in branch '3.8': bpo-38304: Add PyConfig.struct_size (GH-16451) (GH-16453) https://github.com/python/cpython/commit/6e128382b3e7f83d91d5e73d83a051ff5fb6469c --

[issue38304] PEP 587 implementation is not ABI forward compatible

Change by STINNER Victor : -- pull_requests: +16033 pull_request: https://github.com/python/cpython/pull/16453 ___ Python tracker ___

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: New changeset 441b10cf2855955c86565f8d59e72c2efc0f0a57 by Victor Stinner in branch 'master': bpo-38304: Add PyConfig.struct_size (GH-16451) https://github.com/python/cpython/commit/441b10cf2855955c86565f8d59e72c2efc0f0a57 --

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: I updated the PEP 587: https://github.com/python/peps/commit/afa38c0bef7738b8fcc3173daee8488e0420833d -- ___ Python tracker ___

[issue38304] PEP 587 implementation is not ABI forward compatible

Change by STINNER Victor : -- keywords: +patch pull_requests: +16031 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16451 ___ Python tracker ___

[issue38304] PEP 587 implementation is not ABI forward compatible

New submission from STINNER Victor : The current implementation of the PEP 587 is not ready for future evolutions of the PyPreConfig and PyConfig structure. Any change will break the ABI compatibility. Their _config_version field is useless. The first versions of the PEP 587 used a macro to