[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

STINNER Victor added the comment: FYI importlib leak was fixed in bpo-40050 by: commit 83d46e0622d2efdf5f3bf8bf8904d0dcb55fc322 Author: Victor Stinner Date: Tue Mar 24 18:03:34 2020 +0100 bpo-40050: Fix importlib._bootstrap_external (GH-19135) Remove two unused imports:

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Łukasz Langa added the comment: > Reverting GH-18627 fixes the issue. Sorry, this is false. I just checked out to the last commit to importlib before GH-18627 and it did not refleak. But when I actually reverted just GH-18627, the issue persisted. By bisecting, I found out that it's

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Change by Łukasz Langa : -- stage: resolved -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Łukasz Langa added the comment: Re-opening as it causes refleaks all across the stable buildbots. I can reproduce on macOS Catalina as well. Run this to see for yourself: - ./python.exe -E -Wd -m test -uall,-gui -l -L -R: test_importlib Reverting GH-18627 fixes the issue. --

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

STINNER Victor added the comment: New changeset fc72ab6913f2b5337ae7fda711f2de846d38f479 by idomic in branch 'master': bpo-38691: importlib ignores PYTHONCASEOK if -E is used (GH-18627) https://github.com/python/cpython/commit/fc72ab6913f2b5337ae7fda711f2de846d38f479 --

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Ido Michael added the comment: @vstinner ready for review. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Ido Michael added the comment: Added a new clean PR with the code changes, will let you know once the tests are fixed: GH-18627 -- ___ Python tracker ___

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Change by Ido Michael : -- pull_requests: +17991 pull_request: https://github.com/python/cpython/pull/18627 ___ Python tracker ___

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Change by Ido Michael : -- pull_requests: +17977 pull_request: https://github.com/python/cpython/pull/18612 ___ Python tracker ___

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Change by Andy Lester : -- nosy: +petdance ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

STINNER Victor added the comment: > Yes I saw those in the morning, thanks for patching it up. I will debug this > over the weekend and will update. Ok, perfect. In the meanwhile, as announced, I reverted the change to be able to notify other regressions. Once we get a fix, we can reapply

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

STINNER Victor added the comment: New changeset 4dee92b0ad9f4e3ea2f5253340801bb92dc7 by Victor Stinner in branch 'master': Revert "bpo-38691 Added a switch to ignore PYTHONCASEOK when -E or -I flags passed (#18314)" (GH-18553)

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Kyle Stanley added the comment: >From what I can tell, the regression seems like it could be fixed by adding >"@unittest.skipIf(sys.flags.ignore_environment)" to the following tests in >python/cpython/Lib/test/test_importlib/source/test_case_sensitivity.py that >modify "PYTHONCASEOK":

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Ido Michael added the comment: Yes I saw those in the morning, thanks for patching it up. I will debug this over the weekend and will update. -- ___ Python tracker ___

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

STINNER Victor added the comment: > Tests fail on macOS: https://buildbot.python.org/all/#/builders/275/builds/249 Tests are run with "./python.exe ./Tools/scripts/run_tests.py -j 1 -u all -W --slowest --fail-env-changed --timeout=900 -j2 --junit-xml test-results.xml" which runs tests with

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

STINNER Victor added the comment: I'm unable to debug the issue on macOS. I prepared PR 18553 to revert the change, just to give more time to fix the issue. It's to repair the CI, so we can notice other regressions. -- keywords: -newcomer friendly title: [easy] importlib:

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

Change by Brett Cannon : -- nosy: +brett.cannon, eric.snow, ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

New submission from STINNER Victor : When using python3 -E or python3 -I, PYTHONCASEOK environment variable should be ignored by importlib. See an email sent in 2012: https://mail.python.org/pipermail/python-dev/2012-December/123403.html See importlib._bootstrap_external._relax_case attribute