[issue38764] Deterministic globbing.

2019-11-12 Thread Guido van Rossum
Guido van Rossum added the comment: Let's not do this, for all the reasons brought up. -- nosy: +gvanrossum resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue38764] Deterministic globbing.

2019-11-11 Thread Matthew Barnett
Matthew Barnett added the comment: I could also add: would sorting be case-sensitive or case-insensitive? Windows is case-insensitive, Linux is case-sensitive. -- nosy: +mrabarnett ___ Python tracker

[issue38764] Deterministic globbing.

2019-11-11 Thread Raymond Hettinger
Raymond Hettinger added the comment: ISTM that if glob had been sorted, it would have only thinly masked the data pipeline issues that were encountered. The code would still have been easily broken by someone renaming, adding, or removing a file. In their case, it was the semantic context

[issue38764] Deterministic globbing.

2019-11-11 Thread Raymond Hettinger
Raymond Hettinger added the comment: > This seems like an inappropriately elitist attitude. Please drop the personal attacks and abusive tone. The tracker is for technical discussions. -- ___ Python tracker

[issue38764] Deterministic globbing.

2019-11-11 Thread Brandt Bucher
Brandt Bucher added the comment: I'm not sure listdir and walk should be sorted, for the reasons Raymond mentioned. And I was actually surprised to learn today that pathlib.Path.glob doesn't use the glob module internally. Was there some reasoning behind this decision? Separator handling,

[issue38764] Deterministic globbing.

2019-11-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If sort the output of glob(), we should sort also the output of Path.glob(), listdir(), and maybe walk(). -- ___ Python tracker ___

[issue38764] Deterministic globbing.

2019-11-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38764] Deterministic globbing.

2019-11-10 Thread Brandt Bucher
Brandt Bucher added the comment: I disagree somewhat with the assessment that glob provides "thin" access to OS services. It is composed of a few low-level utilities, but it exposes them through what I consider to be a fairly high-level, abstract, friendly interface that (aside from

[issue38764] Deterministic globbing.

2019-11-10 Thread Nathaniel Smith
Nathaniel Smith added the comment: > I saw the article as well, but think auto-sorting would have just provided a > thin mask over their serious data pipeline bugs. This seems like an inappropriately elitist attitude. I'm sure their code has bugs; so does mine and yours. But in fact they did

[issue38764] Deterministic globbing.

2019-11-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: I saw the article as well, but think auto-sorting would have just provided a thin mask over their serious data pipeline bugs. Also, this isn't the only pathway to seeing file lists: os.listdir, fnmatch, etc. I say that we leave it alone and not

[issue38764] Deterministic globbing.

2019-11-10 Thread Brandt Bucher
Change by Brandt Bucher : -- keywords: +patch pull_requests: +16611 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17105 ___ Python tracker ___

[issue38764] Deterministic globbing.

2019-11-10 Thread Brandt Bucher
New submission from Brandt Bucher : This has been discussed before, but we now have examples in the news of glob's non-deterministic behavior causing some real headaches for hundreds of people in the scientific community. After some cursory discussion