[issue38835] pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API

2019-11-20 Thread STINNER Victor
STINNER Victor added the comment: Pablo asked on PR 17231: > Do you want to left the empty macro in Include/pyfpe.h? https://github.com/python/cpython/pull/17231#pullrequestreview-319366200 I replied: > If someone wants to remove them, I would suggest to first deprecate them, and > wait at

[issue38835] pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API

2019-11-20 Thread STINNER Victor
STINNER Victor added the comment: New changeset 488d02a24142948bfb1fafd19fa48e61fcbbabc5 by Victor Stinner in branch 'master': bpo-38835: Exclude PyFPE macros from the stable API (GH-17228) https://github.com/python/cpython/commit/488d02a24142948bfb1fafd19fa48e61fcbbabc5 --

[issue38835] pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API

2019-11-19 Thread STINNER Victor
STINNER Victor added the comment: New changeset be143ec99674ba38c5811f34cdb85ef39c2dc8f8 by Victor Stinner in branch 'master': bpo-38835: Don't use PyFPE_START_PROTECT and PyFPE_END_PROTECT (GH-17231) https://github.com/python/cpython/commit/be143ec99674ba38c5811f34cdb85ef39c2dc8f8

[issue38835] pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API

2019-11-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16731 pull_request: https://github.com/python/cpython/pull/17231 ___ Python tracker ___

[issue38835] pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API

2019-11-18 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +16730 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17228 ___ Python tracker ___

[issue38835] pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API

2019-11-18 Thread STINNER Victor
STINNER Victor added the comment: Python/pyfpe.c still contains two variables (PyFPE_jbuf and PyFPE_counter) and one function (PyFPE_dummy) for ABI compatibility: --- /* These variables used to be used when Python was built with --with-fpectl, * but support for that was dropped in 3.7. We

[issue38835] pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API

2019-11-18 Thread STINNER Victor
New submission from STINNER Victor : The bpo-29137 removed the fpectl module. But two macros were kept in pyfpe.h: /* These macros used to do something when Python was built with --with-fpectl, * but support for that was dropped in 3.7. We continue to define them though, * to avoid breaking