[issue39027] run_coroutine_threadsafe uses wrong TimeoutError

2020-09-28 Thread Nick Gaya
Nick Gaya added the comment: @msg358296: > IMO, it seems rather counter-intuitive to have to specify > `concurrent.futures.TimeoutError` when using a timeout for the future > returned by `run_coroutine_threadsafe()`. I think that's expected, given that the function returns a

[issue39027] run_coroutine_threadsafe uses wrong TimeoutError

2020-09-28 Thread pfctdayelise
pfctdayelise added the comment: Can we at least update the docs in the meantime? It's not great having incorrect docs. Then if a fix is made to revert the behaviour, it can include updating the docs back. -- nosy: +pfctdayelise ___ Python tracker

[issue39027] run_coroutine_threadsafe uses wrong TimeoutError

2019-12-12 Thread Andrew Svetlov
Andrew Svetlov added the comment: futures._chain_future() should convert exceptions. Seems _convert_future_exc() does this work already but maybe it fails somehow. We need to investigate more. -- nosy: +asvetlov ___ Python tracker

[issue39027] run_coroutine_threadsafe uses wrong TimeoutError

2019-12-12 Thread Kyle Stanley
Kyle Stanley added the comment: Thanks for letting us know, janust. I confirmed that `asyncio.TimeoutError` no longer works for the code example in 3.8 and that replacing it with `concurrent.futures.TimeoutError` works correctly. Before moving forward with a PR to the docs, I think we

[issue39027] run_coroutine_threadsafe uses wrong TimeoutError

2019-12-11 Thread janust
New submission from janust : https://docs.python.org/3.8/library/asyncio-task.html#asyncio.run_coroutine_threadsafe has a code example that catches a asyncio.TimeoutError from run_coroutine_threadsafe. In Python 3.7, this exception was equal to concurrent.futures.TimeoutError, but since