[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

miss-islington added the comment: New changeset 1f4cf0c22b00fefb17611546755b65d3cb488330 by Miss Islington (bot) in branch '3.8': bpo-39128: Added algorithm description (GH-18624) https://github.com/python/cpython/commit/1f4cf0c22b00fefb17611546755b65d3cb488330 --

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Andrew Svetlov added the comment: Thanks, Ido -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Change by miss-islington : -- pull_requests: +18008 pull_request: https://github.com/python/cpython/pull/18649 ___ Python tracker ___

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

miss-islington added the comment: New changeset 8af4712a16e4b7d1b60f1faec13cd7a88da95f6a by idomic in branch 'master': bpo-39128: Added algorithm description (GH-18624) https://github.com/python/cpython/commit/8af4712a16e4b7d1b60f1faec13cd7a88da95f6a --

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Ido Michael added the comment: Created new PR and removed the old one GH-18624 -- ___ Python tracker ___ ___ Python-bugs-list

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Change by Ido Michael : -- pull_requests: +17989 pull_request: https://github.com/python/cpython/pull/18624 ___ Python tracker ___

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Ido Michael added the comment: Created 2nd PR with the Algorithm documentation: GH-18523 -- ___ Python tracker ___ ___

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Change by Ido Michael : -- pull_requests: +17900 pull_request: https://github.com/python/cpython/pull/18523 ___ Python tracker ___

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Ido Michael added the comment: Thanks Julien, I forgot about this part, will create a new PR. I thought referencing the abstract of the algorithm + a link to the IETF RFC: Happy Eyeballs: Success with Dual-Stack Hosts When a server's IPv4 path and protocol are working, but the server's

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

miss-islington added the comment: New changeset af95d790a86fc46739badfa9edbaeb264ee96600 by Miss Islington (bot) in branch '3.8': bpo-39128: Added happy_eyeballs_delay, interleave to function signature (GH-18315)

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Julien Palard added the comment: I merged the first PR about adding parameter, but I'm not closing this issue yet, as Andrew said, a small chapter with a description of Happy Eyeballs algorithm would be nice, if anyone want to write a PR, go for it. --

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Change by miss-islington : -- pull_requests: +17804 pull_request: https://github.com/python/cpython/pull/18428 ___ Python tracker ___

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Julien Palard added the comment: New changeset 5305cc9dbfe8a5a0ab666511f3ba7f026c8983f8 by idomic in branch 'master': bpo-39128: Added happy_eyeballs_delay, interleave to function signature (GH-18315) https://github.com/python/cpython/commit/5305cc9dbfe8a5a0ab666511f3ba7f026c8983f8

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Ido Michael added the comment: Created PR added arguments to method signature in doc. GH-18315 -- nosy: +Ido Michael ___ Python tracker ___

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Change by Ido Michael : -- keywords: +patch pull_requests: +17691 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18315 ___ Python tracker ___

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

Andrew Svetlov added the comment: Ideally, a small chapter with a description of Happy Eyeballs algorithm would be nice to have but I don't insist. Updating the method signature is a big step anyway. -- keywords: +easy ___ Python tracker

[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

New submission from Karthikeyan Singaravelan : Created from https://github.com/aio-libs/aiohttp/issues/4451 . happy_eyeballs_delay and interleave are not documented in the signature at [0] though the parameters were explained below . Andrew, feel free to update if there is any additional