[issue39380] ftplib uses latin-1 as default encoding

STINNER Victor added the comment: It's now fixed. Thanks Eric V. Smith for suggesting the change and thanks Sebastian Pedersen for the very complete implementation (with tests and new constructor parameters!). The default encoding change is documented properly in the "Changes in the Python

[issue39380] ftplib uses latin-1 as default encoding

STINNER Victor added the comment: New changeset a1a0eb4a394a5ac7a8422616ce1ee4125a3ef74f by Sebastian Pedersen in branch 'master': bpo-39380: Change ftplib encoding from latin-1 to utf-8 (GH-18048) https://github.com/python/cpython/commit/a1a0eb4a394a5ac7a8422616ce1ee4125a3ef74f --

[issue39380] ftplib uses latin-1 as default encoding

Sebastian G Pedersen added the comment: Yes, I will update the PR before the end of next week. -- ___ Python tracker ___ ___

[issue39380] ftplib uses latin-1 as default encoding

Giampaolo Rodola' added the comment: +1 from me as well. @SebastianGPedersen could you update the PR (constructor + doc changes)? -- ___ Python tracker ___

[issue39380] ftplib uses latin-1 as default encoding

Eric V. Smith added the comment: I agree with Victor. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39380] ftplib uses latin-1 as default encoding

STINNER Victor added the comment: I'm now fine with changing the default. But I would still prefer to have an encoding parameter in the constructor. Making these two changes at once now makes sense to me. -- ___ Python tracker

[issue39380] ftplib uses latin-1 as default encoding

Sebastian G Pedersen added the comment: Thanks again for the engagement. I am also in favor of adding the encoding to the constructor. However, following Giampaolo's comment, that utf-8 is standard and has been for a long time (and the RFC dating back to year 1999), I am also in favor of

[issue39380] ftplib uses latin-1 as default encoding

STINNER Victor added the comment: Before changing the default, I would prefer to see a PR adding an encoding parameter to the FTP constructor. -- ___ Python tracker ___

[issue39380] ftplib uses latin-1 as default encoding

STINNER Victor added the comment: I'm in favor of changing the default encoding to UTF-8, but it requires good documentation, especially to provide a solution working on Python 3.8 and 3.9 to change the encoding (see below). -- The encoding is used to encode commands with the FTP server

[issue39380] ftplib uses latin-1 as default encoding

Inada Naoki added the comment: I'm not FTP user so I don't have strong opinion. If it is too late to change already, change it in 3.9 might be OK. > However, shouldn't it be a FutureWarning, so it will be reported by default > at initialisation? If it is warning for end users, it should be

[issue39380] ftplib uses latin-1 as default encoding

Giampaolo Rodola' added the comment: It's been a long time since I implemented UTF-8 support in pyftpdlib, but long story short is that: - most recent servers are supposed to use UTF-8 by default - such servers must include "UTF-8" in the FEAT command response - some servers may enable UTF-8

[issue39380] ftplib uses latin-1 as default encoding

Sebastian G Pedersen added the comment: Thank you for the feedback. I will elaborate a little bit on the reasons and thoughts behind the pull request: Since RFC 2640, the industry standard within FTP Clients is UTF-8 (see e.g. FileZilla here:

[issue39380] ftplib uses latin-1 as default encoding

Dong-hee Na added the comment: I agree with inada.naoki -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue39380] ftplib uses latin-1 as default encoding

Inada Naoki added the comment: Can we have some deprecation period? def __init__(self, ..., encoding=None): ... if encoding is not None: self.encoding = encoding else: warnings.warn("The default encoding of the FTP class will be changed from 'latin1' to 'utf-8' in

[issue39380] ftplib uses latin-1 as default encoding

New submission from Eric V. Smith : What's the reason behind this change? I love UTF-8 and all, but is there some standard (de facto or de jure) that discusses this? What does this change fix? What's the implication to existing clients? I'm not opposed to the change per se, but I'd like to

[issue39380] ftplib uses latin-1 as default encoding

Change by SilentGhost : -- versions: -Python 3.5, Python 3.6, Python 3.7, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list

[issue39380] ftplib uses latin-1 as default encoding

Change by Sebastian G Pedersen : -- keywords: +patch pull_requests: +17443 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18048 ___ Python tracker

[issue39380] ftplib uses latin-1 as default encoding

Change by Karthikeyan Singaravelan : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue39380] ftplib uses latin-1 as default encoding

Change by Sebastian G Pedersen : -- components: Library (Lib) nosy: SebastianGPedersen priority: normal severity: normal status: open title: ftplib uses latin-1 as default encoding type: behavior versions: Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9