[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Dino Viehland added the comment: I guess the update to lib.pyproj probably just makes the files show up when opening the solution in Visual Studio then. -- ___ Python tracker

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

STINNER Victor added the comment: The Windows installer copies Lib/test/ and subdirectories: see in Tools/msi/test/test.wixproj. -- ___ Python tracker ___

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Dino Viehland added the comment: New changeset 0cd5bff6b7da3118d0c5a88fc2b80f80eb7c3059 by Dino Viehland in branch 'master': bpo-39459: include missing test files in windows installer https://github.com/python/cpython/commit/0cd5bff6b7da3118d0c5a88fc2b80f80eb7c3059 --

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Dino Viehland added the comment: Nope, thank you for pointing that out. I've updated them now with PR 18241 -- ___ Python tracker ___

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Change by Dino Viehland : -- pull_requests: +17621 pull_request: https://github.com/python/cpython/pull/18241 ___ Python tracker ___

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Brett Cannon added the comment: Did the Windows-equivalent project files also get updated? -- ___ Python tracker ___ ___

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

STINNER Victor added the comment: > I've added the files to the makefile and AMD64 Fedora Stable Clang Installed > 3.x was passing. Thanks for the fix! I didn't notice that only "Installed" buildbot workers were impacted. -- ___ Python tracker

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

STINNER Victor added the comment: commit 2528a6c3d0660c03ae43d796628462ccf8e58190 Author: Dino Viehland Date: Mon Jan 27 14:04:56 2020 -0800 Add test.test_import.data.unwritable package to makefile (#18211) -- ___ Python tracker

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Dino Viehland added the comment: I've added the files to the makefile and AMD64 Fedora Stable Clang Installed 3.x was passing. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Change by Dino Viehland : -- pull_requests: +17590 pull_request: https://github.com/python/cpython/pull/18211 ___ Python tracker ___

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Dino Viehland added the comment: Ahh, that's probably it Brett, I didn't know that was there, thanks! -- ___ Python tracker ___

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Brett Cannon added the comment: Was the Makefile updated to install Lib/test/test_import/date/unwritable? -- nosy: +brett.cannon ___ Python tracker ___

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

STINNER Victor added the comment: > AMD64 Fedora Stable Clang Installed 3.x: > https://buildbot.python.org/all/#/builders/127/builds/212 So, I added effective uid/gid to pythoninfo, here you have: os.getegid: 1000 os.geteuid: 1000 os.getgid: 1000 os.getgrouplist: 1000 os.getgroups: 1000

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Dino Viehland added the comment: The curious thing about this is other tests in CircularImportTests are importing packages from test.test_import.data in the exact same way. -- ___ Python tracker

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

STINNER Victor added the comment: New changeset 4a46adc7746930c4589ee483cad88d3f8504c045 by Victor Stinner in branch 'master': bpo-39459: test.pythoninfo logs effective uid/gid (GH-18203) https://github.com/python/cpython/commit/4a46adc7746930c4589ee483cad88d3f8504c045 --

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

STINNER Victor added the comment: > https://src.fedoraproject.org/rpms/python39/pull-request/16 > os.getuid: 0 Maybe this failure comes from the fact that the test suite was run as the root user. I wrote PR 18203 to log the effective uid and gid in pythoninfo, to learn more about this

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Change by STINNER Victor : -- keywords: +patch pull_requests: +17580 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18203 ___ Python tracker ___

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

STINNER Victor added the comment: Issue also seen when building Python 3.9.0a3 on Fedora Rawhide: https://src.fedoraproject.org/rpms/python39/pull-request/16 Logs: https://jenkins-continuous-infra.apps.ci.centos.org/job/fedora-rawhide-pr-pipeline/2558/artifact/package-tests/logs/console.log

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

STINNER Victor added the comment: Same error on x86 Gentoo Installed with X 3.x: https://buildbot.python.org/all/#/builders/128/builds/204 -- ___ Python tracker ___

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

Change by STINNER Victor : -- nosy: +dino.viehland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

STINNER Victor added the comment: Test added in bpo-39336 by: commit 9b6fec46513006d7b06fcb645cca6e4f5bf7c7b8 Author: Dino Viehland Date: Wed Jan 22 16:42:38 2020 -0800 bpo-39336: Allow packages to not let their child modules be set on them (#18006) * bpo-39336: Allow

[issue39459] test_import: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x

New submission from STINNER Victor : AMD64 Fedora Stable Clang Installed 3.x: https://buildbot.python.org/all/#/builders/127/builds/212 test_unwritable_module (test.test_import.CircularImportTests) ... ERROR == ERROR: