[issue40124] Clearer assertion error

Maximilian Hils added the comment: I'm pretty sure this issue is a duplicate of bpo-issue29930. -- nosy: +mhils versions: +Python 3.10 ___ Python tracker ___

[issue40124] Clearer assertion error

Udi added the comment: I don't see anything in the documentation of drain() that states that it cannot be called from multiple tasks. I'm also not sure why this assertion is necessary. If self._drain_waiter is already set, could the other task just await on it? -- nosy: +udifuchs

[issue40124] Clearer assertion error

Chris Jerdonek added the comment: How about we review Phil's PR, which adds a message to the assertion. And then we can keep this issue open to discuss converting the assertion to an exception. I think Phil's PR is an improvement. -- nosy: +chris.jerdonek

[issue40124] Clearer assertion error

Change by SilentGhost : -- versions: -Python 3.5, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40124] Clearer assertion error

Kyle Stanley added the comment: > Do we really want this to be just an assert, or do we want to raise another > type of exception? IMO, we should look into converting this into an exception. Mistakenly having a task await StreamWriter.drain() at the same time as another is calling

[issue40124] Clearer assertion error

Eric V. Smith added the comment: Do we really want this to be just an assert, or do we want to raise another type of exception? I think it's showing a real programming error that we wouldn't want to throw away with -O. -- nosy: +eric.smith ___

[issue40124] Clearer assertion error

New submission from Phil : https://discuss.python.org/t/assertionerror-asyncio-streams-in-drain-helper/3743/4 I recently came across this error, which I now know how to fix. I think the error can be clearer and I've a PR which I think does so. -- components: asyncio messages: 365378

[issue40124] Clearer assertion error

Change by Phil : -- keywords: +patch pull_requests: +18598 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19240 ___ Python tracker ___