[issue40489] INCREF/DECREFs around the rich comparison needs tests

Raymond Hettinger added the comment: Thank you. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40489] INCREF/DECREFs around the rich comparison needs tests

Dong-hee Na added the comment: New changeset 785f5e6d674306052bf865677d885c30561985ae by Dong-hee Na in branch 'master': bpo-40489: Add test case for dict contain use after free (GH-19906) https://github.com/python/cpython/commit/785f5e6d674306052bf865677d885c30561985ae --

[issue40489] INCREF/DECREFs around the rich comparison needs tests

Change by Dong-hee Na : -- keywords: +patch pull_requests: +19221 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19906 ___ Python tracker ___

[issue40489] INCREF/DECREFs around the rich comparison needs tests

Dong-hee Na added the comment: > Would you like to add a test for this case? Oh, I mean, is it good to add a test for this case? -- ___ Python tracker ___

[issue40489] INCREF/DECREFs around the rich comparison needs tests

Dong-hee Na added the comment: Would you like to add a test for this case? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue40489] INCREF/DECREFs around the rich comparison needs tests

Dong-hee Na added the comment: I can crash python interpreter with few lines of code when if we remove those codes. class S(str): def __eq__(self, other): d.clear() return NotImplemented def __hash__(self): return hash('test') d = {S(): 'value'} 'test' in

[issue40489] INCREF/DECREFs around the rich comparison needs tests

Serhiy Storchaka added the comment: See issue1517. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40489] INCREF/DECREFs around the rich comparison needs tests

New submission from Raymond Hettinger : In Objects/dictobject.c, if I remove the INCREF/DECREF pair around PyObject_RichCompareBool(), all the tests still pass: - Py_INCREF(startkey); cmp = PyObject_RichCompareBool(startkey, key, Py_EQ); - Py_DECREF(startkey);